Improvements to import script and other changes #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add manual env parsing - import-papers: add cli arg for archive - import_papers.sh: delete copied archive file from container - frontend: add 'Contribute on GitHub' to footer
|
The latest updates on your projects. Learn more about Vercel for GitHub.
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
| impl EnvVars { | ||
| impl EnvVars { | ||
| /// Parses the environment variables into the struct | ||
| pub fn parse() -> Result<Self, Box<dyn std::error::Error>> { |
Member
There was a problem hiding this comment.
Can this be tested? Shouldn't be too hard ig?
Member
There was a problem hiding this comment.
Either by following this or by creating an issue and making it a future human's problem.
harshkhandeparkar
approved these changes
Oct 21, 2025
Member
harshkhandeparkar
left a comment
harshkhandeparkar
left a comment
There was a problem hiding this comment.
Merge or make any changes if you wish.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Manually parsing env instead of using
clapimport-papers(rust script): Added a CLI argument to specify the filename for the archive. Also has a help command (viaclap)import_papers.sh(bash script): Deleted the copied archive file from the container after processingFrontend: Added 'Contribute on GitHub' to footer
import-papers: Slack notification now shows total unapproved papers as well.I have updated the relevant documentation