Skip to content

Conversation

@saksham-kumar-14
Copy link

Description

Integrated mftp-doctor with mftp and added downtime notifier

Fixes #98

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • notification
Screenshot from 2025-09-08 17-56-39
  • downtime notification
Screenshot from 2025-09-09 04-02-03

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@dhanvithnayak
Copy link
Collaborator

Still working on it or is this ready for review?

@saksham-kumar-14
Copy link
Author

saksham-kumar-14 commented Sep 27, 2025

Still working on it or is this ready for review?

It is ready for review. I haven't updated readme yet
Also I haven't removed the external doctor

@proffapt
Copy link
Member

Still working on it or is this ready for review?

It is ready for review. I haven't updated readme yet Also I haven't removed the external doctor

Please do that. Updating the readme is equally important as the feature.

@dhanvithnayak
Copy link
Collaborator

@saksham-kumar-14 any updates?

@saksham-kumar-14
Copy link
Author

@saksham-kumar-14 any updates?

I’ve added a new function in both mail.py and ntfy.py for handling failure alerts, which is now integrated into send_notices(). It'll be ready for review after I update the readme and make few minor changes

@dhanvithnayak
Copy link
Collaborator

Please do it asap, this has been wip for far too long now

@dhanvithnayak
Copy link
Collaborator

@saksham-kumar-14 status? I could take over if there hasn't been much progress

@saksham-kumar-14
Copy link
Author

I haven't been able to make much progress in it. Please take over

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add downtime notifier to doctor

3 participants