feat: refactor email config to allow SMTP hosts other than Gmail #104
Conversation
|
Thanks for the PRs |
|
Yes, I've setup MFTP with AWS SES with these changes only, and it's working fine. |
proffapt
left a comment
proffapt
left a comment
There was a problem hiding this comment.
Don't change previous variables, only configure the variable which you are adding now
Harshbansal8705
force-pushed
the
feat/email-smtp-refactor
branch
from
927fd9c to
19df025
Compare
|
Got it! I've updated it. |
| FROM_EMAIL = "[email protected]" # Notification Sender Email-id | ||
| FROM_EMAIL_PASS = "**********" # App password for the above email-id | ||
| # SMTP Credentials | ||
| SMTP_HOST = "smtp.gmail.com" | ||
| FROM_EMAIL_USER = "xxxxxxxxxxxxxxxxxxxx" # Same as FROM_EMAIL in case of Gmail SMTP |
There was a problem hiding this comment.
keep a single env instead of duplicated ones.
There was a problem hiding this comment.
FROM_EMAIL_USER is same as FROM_EMAIL in case of Gmail SMTP only. For AWS SES, we have a different SMTP Username, which is why I've kept it different.
There was a problem hiding this comment.
we can remove one of them as it is redundant
There was a problem hiding this comment.
user provides the smtp host and for any host they will need to give username and password
3 participants
Description
Refactor the SMTP credentials to support SMTP hosts other than Gmail, like AWS SES.
Type of change