feat: initial implementation - #1
Merged
Merged
Conversation
vknabel
added
area: control-plane
vknabel
marked this pull request as ready for review
July 13, 2026 07:46
This was referenced Jul 13, 2026
vknabel
added
the
triage
metal-robot
Bot
removed
the
triage
Gerrit91
reviewed
Jul 15, 2026
Comment on lines
+26
to
+36
| lint: true | ||
| test: true | ||
| build: true | ||
| test-command: make test | ||
| build-command: make token-refresher | ||
| registry: ghcr.io | ||
| registry-username: ${{ github.actor }} | ||
| image-name: ${{ github.repository }} | ||
| context: . | ||
| dockerfile: Dockerfile | ||
| artifact-files: "" |
Contributor
There was a problem hiding this comment.
Make us of awesome defaults. :)
| Key: cfg.SecretKey, | ||
| }) | ||
| if err != nil { | ||
| panic(err) |
| return err | ||
| } | ||
|
|
||
| tokSec.Data[ref.Key] = []byte(tokResp.Secret) |
Contributor
There was a problem hiding this comment.
Nil check for data map is missing
Contributor
Author
There was a problem hiding this comment.
inserted above (the token must be provided in order to refresh it)
| spec.AnnotationTokenIssuedAt: "2006-01-02T14:04:05Z", | ||
| }, | ||
| }, | ||
| Data: map[string][]byte{ |
Contributor
There was a problem hiding this comment.
Test when nothing is in data (nil)
Co-authored-by: Gerrit <Gerrit91@users.noreply.github.com>
Gerrit91
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TODOs
Used AI-Tools ✨
Related
After Merge
v0.1.0area: control-plane(prepared in private repo)