Skip to content

✨ Add read only mode for local ironic run #2278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Rozzii wants to merge 1 commit into
base: main
Choose a base branch
from
Open

✨ Add read only mode for local ironic run #2278

Rozzii wants to merge 1 commit into from

Conversation

@Rozzii
Copy link
Member

@Rozzii Rozzii commented Mar 5, 2025

This PR:

  • Adds an option to the local ironic deployment script to run the containers with a read-only file system
  • Adds additional mounts for the Ironic containers regardless if a container runs with a read-only file system or not

This commit is needed because otherwise developers would be unable to run the local ironic deployment with read-only root file system.

Related to: metal3-io/ironic-image#613
IRSO and BMO ironic-deployment overlays will need this config also.

@metal3-io-bot metal3-io-bot requested review from mquhuy and tuminoid March 5, 2025 10:05
@metal3-io-bot
Copy link
Contributor

metal3-io-bot commented Mar 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from rozzii. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 5, 2025
@Rozzii Rozzii changed the title Add read only mode for local ironic run ❇️ Add read only mode for local ironic run Mar 5, 2025
tuminoid
tuminoid reviewed Mar 5, 2025
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not against cleaning the bash here, but can you do it in separate commit or in separate PR as it is making super hard to identify the actual change here.

@Rozzii Rozzii force-pushed the read_only_file_system_ironic branch from 0e7068d to 00ffe3d Compare March 5, 2025 10:08
@Rozzii
Add read only mode for local ironic run
fd0b87d 
This commit:
 - Adds an option to the local ironic deployment script to run the
   containers with a read-only file system
 - Adds additional mounts for the Ironic containers regardless if a container
   runs with a read-only file system or not

This commit is needed because otherwise developers would be unable to run
the local ironic deployment with read-only root file system.

Signed-off-by: Adam Rozman <[email protected]>
@Rozzii Rozzii force-pushed the read_only_file_system_ironic branch from 00ffe3d to fd0b87d Compare March 5, 2025 10:30
@Rozzii Rozzii changed the title ❇️ Add read only mode for local ironic run ✨ Add read only mode for local ironic run Mar 5, 2025
@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Mar 19, 2025
@metal3-io-bot
Copy link
Contributor

metal3-io-bot commented Mar 19, 2025

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot
Copy link
Contributor

metal3-io-bot commented Jun 17, 2025

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 17, 2025
@Rozzii
Copy link
Member Author

Rozzii commented Jun 18, 2025

/remove-lifecycle stale
No no, at this point everything is in place for this to work.

@metal3-io-bot metal3-io-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 18, 2025
@metal3-io-bot
Copy link
Contributor

metal3-io-bot commented Sep 16, 2025

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 16, 2025
@tuminoid
Copy link
Member

tuminoid commented Sep 16, 2025

/remove-lifecycle stale

@metal3-io-bot metal3-io-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 16, 2025
@metal3-io-bot
Copy link
Contributor

metal3-io-bot commented Dec 15, 2025

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 15, 2025
@tuminoid
Copy link
Member

tuminoid commented Dec 15, 2025

Should we abandon this due IRSO being the way to install Ironic now?

@Rozzii
Copy link
Member Author

Rozzii commented Dec 15, 2025

I can move this deployment method to dev-env , if BMO will only host IrSO based deployments.
/remove-lifecycle stale

@metal3-io-bot metal3-io-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tuminoid tuminoid tuminoid left review comments

@mquhuy mquhuy Awaiting requested review from mquhuy

Assignees

No one assigned

Labels

needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Rozzii @metal3-io-bot @tuminoid