:sparkles: introduce preprovisioningKernelParams to BMH by Rozzii · Pull Request #2576 · metal3-io/baremetal-operator

Rozzii · 2025-07-21T12:50:31Z

This PR:

Implements support for additional kernel parameters during preprovisioning
Adds PreprovisioningExtraKernelParams spec field to BareMetalHost CRD
Implements kernel parameter combination logic between BMH and PreprovisioningImage CRs
Adds comprehensive unit tests for parameter combination scenarios
Renames getInstanceUpdateOpts to getProvisioningInstanceUpdateOptsForNode for consistency
Updates BMC access utilities to support extra kernel parameters
Adds PreprovisioningExtraKernelParams field to ManagementAccessData struct
for provisioner interface
Extends kernel extra preprov param handling to account for different preprov
image scenarios (external initrd, external iso, self made PPI, unknown format, no PPI)
Adds ownership detection logic to distinguish external vs BMO-managed PreprovisioningImages
Adds BMO internal defaultPPImgFormat constant for internal BMO-managed PPI identification
Extends default PPI provider and reconciler to handle extraKernelParams

Notes:

The new spec field is optional and maintains backward compatibility
ISO format PreprovisioningImages ignore BMH kernel params with warning
In case of externally managed PreprovisioningImages with InitRD image format
BMO will combine both BMH and PPI kernel params
Kernel parameters cannot be changed during fast-track deployments

Other info:

Related design PR: Propose BMH specific preprovisioningExtraKernelParams spec field metal3-docs#552
E2E test will be done in separate PR
I will open an issue related to a discussion about exploring status fields, events, and conditions related to the kernel parameters.

Rozzii · 2025-07-21T15:08:02Z

/retest

Rozzii · 2025-07-23T08:13:33Z

/ok-to-test

Rozzii · 2025-07-23T11:27:17Z

@dtantsur this is the initial idea based on the proposal, I am testing it manually , so far it worked I think I will add the e2e in a separate PR, but I think I need to add some unit testing still to this PR.

Rozzii · 2025-07-23T11:27:43Z

/cc @dtantsur

Rozzii · 2025-08-13T21:33:40Z

I think the essential parts are there, I will push an e2e related PR as a followup but this is long enough as it is.

Commits will be squashed if folks are okay with the implementation, but I will keep them separate for the time being.

Rozzii · 2025-08-14T08:59:19Z

/cc @fmuyassarov @lentzi90

Rozzii · 2025-08-14T11:50:50Z

/cc @kashifest
FYI

kashifest · 2025-08-14T19:37:12Z

/cc @zaneb @dtantsur

metal3-io-bot · 2026-03-18T13:12:13Z

@Rozzii: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
markdownlint	`82c2e16`	link	true	`/test markdownlint`
test	`82c2e16`	link	true	`/test test`
shellcheck	`82c2e16`	link	true	`/test shellcheck`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Rozzii · 2026-03-18T13:13:57Z

/hold
I am still working on the refactoring.

Rozzii · 2026-04-18T09:20:01Z

/hold cancel

Copilot

Pull request overview

This PR adds support for passing extra kernel parameters to the preprovisioning agent by introducing a new optional preprovisioningExtraKernelParams field on the BareMetalHost API, plumbing it through the controller/provisioner layers, and extending Ironic driver-info updates and unit tests to cover parameter formatting/combination behavior.

Changes:

Add spec.preprovisioningExtraKernelParams to the BMH API/CRDs and propagate it via ManagementAccessData.
Update Ironic provisioning to format/apply extra preprovisioning kernel params (kernel_append_params) and adjust BMC access DriverInfo signatures accordingly.
Add/extend controller logic and tests to locate the owning BMH for a PPI and to combine kernel params across BMH/PPI scenarios.

Reviewed changes

Copilot reviewed 24 out of 24 changed files in this pull request and generated 12 comments.

Show a summary per file

File	Description
`apis/metal3.io/v1alpha1/baremetalhost_types.go`	Adds the new BMH spec field and its GoDoc.
`config/base/crds/bases/metal3.io_baremetalhosts.yaml`	Adds the new CRD schema field/description.
`config/render/capm3.yaml`	Adds the rendered CRD schema field/description.
`pkg/provisioner/provisioner.go`	Extends `ManagementAccessData` with `PreprovisioningExtraKernelParams`.
`internal/controller/metal3.io/baremetalhost_controller.go`	Adds reconciliation-time kernel param combination logic and passes it to the provisioner.
`internal/controller/metal3.io/baremetalhost_controller_test.go`	Adds unit tests for kernel param retrieval/combination scenarios.
`internal/controller/metal3.io/preprovisioningimage_controller.go`	Adds owner BMH lookup and mutates generated image kernel params for initrd.
`internal/controller/metal3.io/preprovisioningimage_controller_test.go`	Adds unit tests for `findOwnerBMH`.
`pkg/provisioner/ironic/ironic.go`	Adds kernel-param formatting helper, updates deploy-image logic, renames update-opts function.
`pkg/provisioner/ironic/register.go`	Passes formatted kernel params into BMC driver-info and adds conditional driver-info update logic.
`pkg/provisioner/ironic/register_test.go`	Updates deploy-image tests to use the new `ManagementAccessData` plumbing.
`pkg/provisioner/ironic/ironic_test.go`	Adds unit tests for `fmtPreprovExtraKernParams`.
`pkg/provisioner/ironic/provision_test.go`	Updates call sites for the renamed update-opts helper.
`pkg/provisioner/ironic/inspecthardware.go`	Adds an info log when node update does not start.
`pkg/provisioner/ironic/testbmc/testbmc.go`	Updates test BMC access driver-info to accept/publish kernel params.
`pkg/provisioner/ironic/prepare_test.go` / `pkg/provisioner/ironic/servicing_test.go`	Updates fake BMC implementations for the new `DriverInfo` signature.
`pkg/hardwareutils/bmc/access.go`	Changes `AccessDetails.DriverInfo` interface signature to include extra kernel params.
`pkg/hardwareutils/bmc/ipmi.go` / `redfish*.go` / `idrac_virtualmedia.go`	Adds `kernel_append_params` into driver-info maps.
`pkg/hardwareutils/bmc/access_test.go`	Updates expected driver-info maps and call signatures.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

This commit: - Implements support for additional kernel parameters during preprovisioning - Add PreprovisioningExtraKernelParams spec field to BareMetalHost CRD - Implement kernel parameter combination logic between BMH and PreprovisioningImage CRs - Add comprehensive unit tests for parameter combination scenarios - Rename getInstanceUpdateOpts to getProvisioningInstanceUpdateOptsForNode for consistency - Update BMC access utilities to support extra kernel parameters - Add PreprovisioningExtraKernelParams field to ManagementAccessData struct for provisioner interface - Extend kernel extra preprov param handling to account for different preprov image scenarios (external initrd, external iso, self made PPI, unknown format, no PPI) - Add ownership detection logic to distinguish external vs BMO-managed PreprovisioningImages - Add BMO internal defaultPPImgFormat constant for internal BMO-managed PPI identification Notes: - The new spec field is optional and maintains backward compatibility - ISO format PreprovisioningImages ignore BMH kernel params with warning - In case of externally managed PreprovisioningImages with InitRD image format BMO will combine both BMH and PPI kernel params - Kernel parameters cannot be changed during fast-track deployments Signed-off-by: Adam Rozman <adam.rozman@est.tech>

lentzi90 · 2026-04-22T09:57:37Z

+		{
+			name:     "params with leading/trailing spaces",
+			input:    "  console=ttyS0 debug=1  ",
+			expected: defaultKernelParam + "   console=ttyS0 debug=1  ",


Shouldn't we trim the extra spaces?

Kernel params are space separated, the number of spaces shouldn't matter. Current approach is that we do the absolute minimum modification to the params. (Basically only the concatenation) That said we can trim them I am not against it.

lentzi90 · 2026-04-22T09:58:40Z

+		return defaultKernelParam
+	}
+	// spacing matters for kernel params
+	return defaultKernelParam + " " + params


Shouldn't we return the trimmed params instead of the original?

Suggested change

return defaultKernelParam + " " + params

return defaultKernelParam + " " + trimmedParams

Same is above, not mandatory but we can trim them I am not against that.

Ok, I think it would be nice to trim the "edges". This behavior of just trimming to see if it turns up empty is a bit surprising

lentzi90 · 2026-04-22T10:03:05Z

+// HasFirmwareSpec True if any firmware spec exists (settings, components, or
+// legacy FirmwareConfig), used to distinguish "no updates" from "user cleared spec".


The comment makes more sense where it was I think

I did this because the linter started complaining, I might be doing something wrong but I was unable to shut up the golangci linter any other way.

lentzi90 · 2026-04-22T10:32:43Z

+			CurrentImage:                     getCurrentImage(info.host),
+			PreprovisioningImage:             preprovImg,
+			PreprovisioningNetworkData:       preprovisioningNetworkData,
+			PreprovisioningExtraKernelParams: r.retrievePreprovisioningExtraKernelParamsSpec(ctx, info, prov),


We have preprovImg up on line 923 that we could pass in here. That way we can skip the getPreprovImage call in retrievePreprovisioningExtraKernelParamsSpec.

Yeah that makes sense, I will check how big of a change that would be .

lentzi90 · 2026-04-22T10:37:46Z

 	bmcType                        string
 	hostname                       string
 	disableCertificateVerification bool
+	driverInfo                     string


Do we need this? I don't see it used anywhere.

lentzi90 · 2026-04-22T10:43:17Z

 	// expected to add any other information that might be needed
 	// (such as the kernel and ramdisk locations).
-	DriverInfo(bmcCreds Credentials) map[string]interface{}
+	DriverInfo(bmcCreds Credentials, preprovExtraKernelArgs string) map[string]interface{}


Is it necessary to change DriverInfo? I saw there was a comment before about this but I didn't get the conclusion.

It might be doable via instance info I am not sure about it, but we are already using driver info and we are updating driver info at every reconciliation if needed already.

Relation to the drivers:
If you check ironic-image you can see that in ironic.conf we are setting driver specific defaults for kernel params so I felt if we are manipulating these values on a driver level in ironic I would just follow along. In the previous comment it was pointed out that I am setting kernel params her https://github.com/metal3-io/baremetal-operator/pull/2576/changes/BASE..7cdcfb5cda0ae8b32e75dc645c4da18bd7defd65#diff-f05fc4a0c9679815bc34bcef100c2a8d525688f2804a1128c5b9e1e575b76c29L326 but this also ends up setting the driver_info at the en off the call chain.

Granularity:
Might be that in the future there will be a driver that won't support kernel param injection on a per node basis or only with limitations, this injection is done differently for different drivers on the provisioner level. An other thing is that we are representing/mirroring the ironic dirver_info in BMO for supported drivers already so I thought why not just extend the BMO representation of the driver_info with what we have on the ironic side anyways.

metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 21, 2025

metal3-io-bot requested review from elfosardo and honza July 21, 2025 12:50

metal3-io-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 21, 2025

Rozzii added this to Metal3 - Roadmap Jul 21, 2025

Rozzii moved this to BMO WIP in Metal3 - Roadmap Jul 21, 2025

Rozzii added this to the BMO - v0.11 milestone Jul 21, 2025

Rozzii mentioned this pull request Jul 22, 2025

Propose BMH specific preprovisioningExtraKernelParams spec field metal3-io/metal3-docs#552

Open

Rozzii force-pushed the node_spec_kern_args branch 2 times, most recently from 078696a to 88beeae Compare July 23, 2025 08:12

metal3-io-bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 23, 2025

Rozzii force-pushed the node_spec_kern_args branch from 88beeae to 5322972 Compare July 23, 2025 10:31

metal3-io-bot requested a review from dtantsur July 23, 2025 11:27

Rozzii mentioned this pull request Aug 5, 2025

[New Feature] Add option to run "Automated Cleaning" only for initial provisioning #2589

Open

Rozzii force-pushed the node_spec_kern_args branch 2 times, most recently from 4516861 to 7ae19c9 Compare August 7, 2025 13:08

Rozzii changed the title ~~WIP ✨ introduce preprovisioningKernelParams to BMH~~ ✨ introduce preprovisioningKernelParams to BMH Aug 14, 2025

metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 14, 2025

metal3-io-bot requested review from fmuyassarov and lentzi90 August 14, 2025 08:59

metal3-io-bot requested a review from kashifest August 14, 2025 11:50

metal3-io-bot requested a review from zaneb August 14, 2025 19:37

Rozzii force-pushed the node_spec_kern_args branch from 82c2e16 to 9b51b3e Compare January 29, 2026 09:56

metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Jan 29, 2026

metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Feb 19, 2026

Rozzii force-pushed the node_spec_kern_args branch from 9b51b3e to f50616e Compare March 18, 2026 13:11

Rozzii force-pushed the node_spec_kern_args branch from f50616e to 8126b0a Compare March 18, 2026 13:12

metal3-io-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 18, 2026

metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2026

Rozzii force-pushed the node_spec_kern_args branch from 8126b0a to f82b0e0 Compare March 18, 2026 19:59

Rozzii force-pushed the node_spec_kern_args branch from f82b0e0 to bd23be7 Compare April 16, 2026 09:21

metal3-io-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 16, 2026

Rozzii force-pushed the node_spec_kern_args branch 2 times, most recently from f447d3c to 9f0e183 Compare April 17, 2026 13:05

metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2026

tuminoid requested a review from Copilot April 19, 2026 16:44

Copilot started reviewing on behalf of tuminoid April 19, 2026 16:45 View session

Copilot AI reviewed Apr 19, 2026

View reviewed changes

Rozzii mentioned this pull request Apr 21, 2026

🐛 Add missing context to PreprovisioningImageFormats func #3165

Merged

Rozzii force-pushed the node_spec_kern_args branch from 9f0e183 to a743279 Compare April 21, 2026 18:31

metal3-io-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 21, 2026

Rozzii force-pushed the node_spec_kern_args branch from a743279 to 45d368d Compare April 21, 2026 20:12

Rozzii force-pushed the node_spec_kern_args branch from 45d368d to 7cdcfb5 Compare April 22, 2026 05:58

lentzi90 reviewed Apr 22, 2026

View reviewed changes

	return defaultKernelParam + " " + params
	return defaultKernelParam + " " + trimmedParams

		// HasFirmwareSpec True if any firmware spec exists (settings, components, or
		// legacy FirmwareConfig), used to distinguish "no updates" from "user cleared spec".

Conversation

Rozzii commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Rozzii commented Jul 21, 2025

Uh oh!

Rozzii commented Jul 23, 2025

Uh oh!

Rozzii commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Rozzii commented Jul 23, 2025

Uh oh!

Rozzii commented Aug 13, 2025

Uh oh!

Rozzii commented Aug 14, 2025

Uh oh!

Rozzii commented Aug 14, 2025

Uh oh!

kashifest commented Aug 14, 2025

Uh oh!

metal3-io-bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Rozzii commented Mar 18, 2026

Uh oh!

Rozzii commented Apr 18, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Rozzii Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Rozzii commented Jul 21, 2025 •

edited

Loading

Rozzii commented Jul 23, 2025 •

edited

Loading

metal3-io-bot commented Mar 18, 2026 •

edited

Loading

Rozzii Apr 22, 2026 •

edited

Loading