Skip to content

Conversation

@lentzi90
Copy link
Member

What this PR does / why we need it:

Switch e2e tests to UEFI instead of Legacy.
(Second attempt)

Fixes #1607

Checklist:

  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • E2E tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign honza for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 12, 2025
@lentzi90 lentzi90 force-pushed the lentzi90/e2e-uefi branch 2 times, most recently from 55be93f to c709b4e Compare November 13, 2025 06:57
@metal3-io-bot metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 13, 2025
@lentzi90
Copy link
Member Author

/hold
WIP

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2025
@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 17, 2025
Switch e2e tests to UEFI instead of Legacy.

Signed-off-by: Lennart Jern <[email protected]>
Signed-off-by: Lennart Jern <[email protected]>
@metal3-io-bot metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 18, 2025
# system architecture. Ideally the x86_64 loader will be capable
# of secure boot or not based on the chosen nvram.
SUSHY_EMULATOR_BOOT_LOADER_MAP = {
u'UEFI': {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we mean to remove the UEFI block entry too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried to remove everything that isn't strictly necessary. This part is all default values from what I understand so it is not needed.

The last missing thing in this PR (I think) is the image we use for provisioning tests. I can see inspection is passing, so IPA is able to boot with UEFI. However, the ssh test after Cirros has been written to disk fails. I have been meaning to try a centos/ubuntu image instead to check if that is the issue, but so far I didn't manage to find the time.
There may also be something more wrong with the IPMI test. Perhaps there is some issue when doing PXE -> UEFI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use UEFI boot mode instead of legacy

3 participants