-
Notifications
You must be signed in to change notification settings - Fork 290
🌱 E2E: Use UEFI #2770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
🌱 E2E: Use UEFI #2770
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
55be93f to
c709b4e
Compare
b9cf421 to
265449a
Compare
|
/hold |
265449a to
ff1aea4
Compare
Switch e2e tests to UEFI instead of Legacy. Signed-off-by: Lennart Jern <[email protected]>
Signed-off-by: Lennart Jern <[email protected]>
ff1aea4 to
7c95cbb
Compare
| # system architecture. Ideally the x86_64 loader will be capable | ||
| # of secure boot or not based on the chosen nvram. | ||
| SUSHY_EMULATOR_BOOT_LOADER_MAP = { | ||
| u'UEFI': { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we mean to remove the UEFI block entry too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tried to remove everything that isn't strictly necessary. This part is all default values from what I understand so it is not needed.
The last missing thing in this PR (I think) is the image we use for provisioning tests. I can see inspection is passing, so IPA is able to boot with UEFI. However, the ssh test after Cirros has been written to disk fails. I have been meaning to try a centos/ubuntu image instead to check if that is the issue, but so far I didn't manage to find the time.
There may also be something more wrong with the IPMI test. Perhaps there is some issue when doing PXE -> UEFI.
What this PR does / why we need it:
Switch e2e tests to UEFI instead of Legacy.
(Second attempt)
Fixes #1607
Checklist: