Skip to content

Conversation

@Sunnatillo
Copy link
Member

What this PR does / why we need it:
This PR adds explanation to run verify-release.sh script to releasing.md. Also, changes tag mentions from 1.x.x to 0.x.x to avoid accidental mistakes

Checklist:

  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • E2E tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rozzii for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 12, 2025
@Sunnatillo Sunnatillo force-pushed the Sunnatillo/improve-release-document branch from 6590a9f to dad6780 Compare November 12, 2025 15:31
@Sunnatillo Sunnatillo changed the title 🌱 Add explanation to run verify-release.sh script to releasing.md 🌱 Add explanation to run verify-release.sh script in releasing.md Nov 12, 2025
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One questions, otherwise LGTM.

@tuminoid
Copy link
Member

/retitle 📖 Add explanation to run verify-release.sh script in releasing.md

@metal3-io-bot metal3-io-bot changed the title 🌱 Add explanation to run verify-release.sh script in releasing.md 📖 Add explanation to run verify-release.sh script in releasing.md Nov 12, 2025
@Sunnatillo Sunnatillo force-pushed the Sunnatillo/improve-release-document branch 3 times, most recently from 1a975cd to 8b49ac0 Compare November 17, 2025 09:24
Also, change tag mentions from 1.x.x to 0.x.x to avoid mistakes

Signed-off-by: Sunnatillo <[email protected]>
@Sunnatillo Sunnatillo force-pushed the Sunnatillo/improve-release-document branch from 8b49ac0 to 9ea0c63 Compare December 8, 2025 08:19
@kashifest
Copy link
Member

/cc @kashifest

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2025
@MahnoorAsghar
Copy link
Contributor

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants