Skip to content

Conversation

@dankingtech
Copy link

Added an "n" that would break spell checkers.

Added an "n" that would break spell checkers.
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dtantsur for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 21, 2025
@metal3-io-bot
Copy link
Contributor

Hi @dankingtech. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 21, 2025
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retitle 🌱 Fix spelling error metal3.io_baremetalhosts.yaml line 624

Please sign the DCO.
/ok-to-test

@metal3-io-bot metal3-io-bot changed the title 🐛 Fix spelling error metal3.io_baremetalhosts.yaml line 624 🌱 Fix spelling error metal3.io_baremetalhosts.yaml line 624 Nov 24, 2025
@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 24, 2025
@metal3-io-bot
Copy link
Contributor

@dankingtech: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
generate db88865 link true /test generate

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@MahnoorAsghar
Copy link
Contributor

Hi @dankingtech!
Please fix this here:

// ErrorCount records how many times the host has encoutered an error since the last successful operation
// +kubebuilder:default:=0
, and run 'make generate manifests'

@shenwei66
Copy link

Hi @dankingtech!

Please fix this here:

// ErrorCount records how many times the host has encoutered an error since the last successful operation
// +kubebuilder:default:=0
, and run 'make generate manifests'

Agree,this is the root cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants