🌱 add unit tests to SecretManager

[tuminoid]

Add unit tests to SecretManager, similar to IRSO's tests in metal3-io/ironic-standalone-operator#441 . Take some, give some!

Checklist:

• Documentation has been updated, if necessary.
• Unit tests have been added, if necessary.
• E2E tests have been added, if necessary.
• Integration tests have been added, if necessary.

[metal3-io-bot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[tuminoid]

/cc @dtantsur @elfosardo

[tuminoid]

Fixed similar issues as in source PR, and rebased.

[kashifest]

Its been long I have used these assertions. When something breaks in the code, would this output the reason of the failure as logs from the code or just the failure since I don't see any log outputs here. I mean the test itself is not generating any log but would it atleast propagate the failure log from the code itself it is testing ?

[kashifest]

/approve
/hold
I have a question in line

[metal3-io-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [kashifest]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tuminoid]

Its been long I have used these assertions. When something breaks in the code, would this output the reason of the failure as logs from the code or just the failure since I don't see any log outputs here. I mean the test itself is not generating any log but would it atleast propagate the failure log from the code itself it is testing ?

Unit tests should never log by design. They assert, which tell the failure reason. None of the unit tests in BMO or in our other repos print logs.

[kashifest]

Unit tests should never log by design. They assert, which tell the failure reason. None of the unit tests in BMO or in our other repos print logs.

Ok so it will propagate the failure reason. I was not meaning add logs here. My question was how assert handles the failure reason.

/hold cancel

[MahnoorAsghar]

lgtm