🌱 e2e: pre-pull images to work around kind ctr import issue #2833
Conversation
|
Skipping CI for Draft Pull Request. |
metal3-io-bot
added
the
do-not-merge/work-in-progress
metal3-io-bot
added
the
size/M
tuminoid
force-pushed
the
tuomo/fix-bmo-optional
branch
from
9a19b33 to
0e1200a
Compare
|
/test ? |
|
@tuminoid: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test metal3-bmo-e2e-test-optional-pull |
The clusterctl.ContainerImage struct from CAPI has no yaml struct tags, so when gopkg.in/yaml.v2 unmarshals the e2e config, the LoadBehavior field remains empty. The Defaults() function then sets LoadBehavior to MustLoadImage, causing all image load failures to be fatal instead of the intended tryLoad (warning only) behavior. This adds a local ContainerImage struct with proper yaml tags and a conversion method to use with CAPI's bootstrap framework. Signed-off-by: Tuomo Tanskanen <[email protected]>
tuminoid
force-pushed
the
tuomo/fix-bmo-optional
branch
from
0e1200a to
79c3d87
Compare
|
/test metal3-bmo-e2e-test-optional-pull |
|
OK, it worked, but failed to other random issue. |
tuminoid
changed the title
metal3-io-bot
removed
the
do-not-merge/work-in-progress
|
/retest |
|
/override metal3-bmo-e2e-test-optional-pull Prow based BMO optional pull is broken - I think need work to make namespaced secrets work. Log is full of RBAC issues. @Sunnatillo @lentzi90 This will fix the docker issue though, so this should be merged. |
|
@tuminoid: Overrode contexts on behalf of tuminoid: metal3-bmo-e2e-test-optional-pull DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
lentzi90
left a comment
lentzi90
left a comment
There was a problem hiding this comment.
/approve
Actually I saw at least one of the tests fail with the error that is fixed in #2827. Catch 22 🙃
Most of the RBAC error stuff is because of "overlap" between things we clean up. It would be nice to get sorted but should be harmless.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adilGhaffarDev, lentzi90 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
The ContainerImage struct was missing json struct tags, unlike all other configuration structs in e2e_config.go. While sigs.k8s.io/yaml (used by CAPI) handles this correctly via case-insensitive JSON unmarshaling, adding explicit tags: - Maintains consistency with other structs in the file - Documents the expected field names explicitly - Protects downstream consumers using gopkg.in/yaml.v2 directly This was identified while fixing a related issue in baremetal-operator where gopkg.in/yaml.v2 failed to unmarshal loadBehavior without tags, causing all image loads to default to MustLoadImage. Ref: metal3-io/baremetal-operator#2833
4 participants
The clusterctl.ContainerImage struct from CAPI has no yaml struct tags, so when gopkg.in/yaml.v2 unmarshals the e2e config, the LoadBehavior field remains empty. The Defaults() function then sets LoadBehavior to MustLoadImage, causing all image load failures to be fatal instead of the intended tryLoad (warning only) behavior.
This adds a local ContainerImage struct with proper yaml tags and a conversion method to use with CAPI's bootstrap framework.
Fixes: #2832