🌱 e2e: retry reconcile loop after patching

[tuminoid]

Do another round of fixing into BMO patching for e2e optional.

[tuminoid]

/test ?

[metal3-io-bot]

@tuminoid: The following commands are available to trigger required jobs:

/test generate

/test gomod

/test manifestlint

/test markdownlint

/test shellcheck

/test test

The following commands are available to trigger optional jobs:

/test metal3-bmo-e2e-test-optional-pull

/test metal3-centos-e2e-basic-test-main

/test metal3-centos-e2e-feature-test-main-features

/test metal3-centos-e2e-feature-test-main-pivoting

/test metal3-centos-e2e-feature-test-main-remediation

/test metal3-centos-e2e-integration-k8s-pre-release-test-main

/test metal3-centos-e2e-integration-test-main

/test metal3-dev-env-integration-test-centos-main

/test metal3-dev-env-integration-test-ubuntu-main

/test metal3-e2e-1-33-1-34-upgrade-test-main

/test metal3-e2e-clusterctl-upgrade-test-main

/test metal3-ubuntu-e2e-basic-test-main

/test metal3-ubuntu-e2e-feature-test-main-features

/test metal3-ubuntu-e2e-feature-test-main-pivoting

/test metal3-ubuntu-e2e-feature-test-main-remediation

/test metal3-ubuntu-e2e-integration-k8s-pre-release-test-main

/test metal3-ubuntu-e2e-integration-test-main

Use /test all to run the following jobs that were automatically triggered:

generate

gomod

manifestlint

Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tuminoid]

/test metal3-bmo-e2e-test-optional-pull

[tuminoid]

BMO optional pull passed, so BMO optional e2e should pass too when merged.

/cc @lentzi90 @kashifest

[lentzi90]

Looks good! I see one potential corner case that we don't handle: webhook is ready but somehow the controller is not. Then it will miss the annotation and get stuck I guess?
Should we rather remove the annotation and patch again on each try make sure?

[tuminoid]

Looks good! I see one potential corner case that we don't handle: webhook is ready but somehow the controller is not. Then it will miss the annotation and get stuck I guess? Should we rather remove the annotation and patch again on each try make sure?

That is practically impossible, but possible in theory, but removing the annotation in e2e is harmless, possibly just triggering second reconcile in an edge case, so I'm going to implement the suggestion.

[tuminoid]

/test metal3-bmo-e2e-test-optional-pull

[lentzi90]

/approve
/hold
for optional tests to pass

[kashifest]

/lgtm

[metal3-io-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest, lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [kashifest,lentzi90]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tuminoid]

Tests passed.

/unhold