WIP e2e tests for forced detachment#3072
Open
dtantsur wants to merge 4 commits intometal3-io:mainfrom
Open
Conversation
metal3-io-bot
added
the
do-not-merge/work-in-progress
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
metal3-io-bot
added
the
size/XL
metal3-io-bot
added
the
needs-rebase
Adds Force as DetachedAnnotationArgument to API. Detach in all states if force is set to true by aborting the currently running process. Co-Authored-By: Dmitry Tantsur <dtantsur@protonmail.com> Signed-off-by: CrystalChun <cchun@redhat.com> Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
The deletion logic does not need to be aware of which states are valid for detachment. If the operationalStatus is detached, the host can be deleted immediately. Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
Exercise forced detachment followed by deletion, new enrollment and finished provisioning. Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
dtantsur
force-pushed
the
force-detachment-e2e
branch
from
13bb2e2 to
aaac6ac
Compare
metal3-io-bot
removed
the
needs-rebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2955