🌱 Add unit tests for getDiskType, getStorageDetails, getCPUDetails, getSystemVendorDetails#3150
Conversation
…etSystemVendorDetails Signed-off-by: Artem Muterko <artem@sopho.tech>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
metal3-io-bot
added
the
needs-ok-to-test
|
Hi @archy-rock3t-cloud. Thanks for your PR. I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
metal3-io-bot
added
the
size/L
tuminoid
left a comment
tuminoid
left a comment
There was a problem hiding this comment.
/ok-to-test
Thanks! Could we address some edge cases more?
- getcpudetails invalid/empty frequency string
- nil input to getcpudetails
- nil input for getstoragedetails
- getstoragedetails with empty name but non-empty path
| assert.Equal(t, metal3api.HDD, getDiskType(inventory.RootDiskType{Rotational: true})) | ||
| assert.Equal(t, metal3api.NVME, getDiskType(inventory.RootDiskType{Name: "/dev/nvme0n1"})) | ||
| assert.Equal(t, metal3api.NVME, getDiskType(inventory.RootDiskType{Name: "/dev/nvme0n1p1"})) | ||
| assert.Equal(t, metal3api.SSD, getDiskType(inventory.RootDiskType{Name: "/dev/sda"})) |
metal3-io-bot
added
ok-to-test
3 participants
What this PR does / why we need it:
Add unit tests for getDiskType, getStorageDetails, getCPUDetails, getSystemVendorDetails
Checklist: