✨ Update logic for HostClaims

apis/metal3.io/v1alpha1/baremetalhost_types.go

@@ -699,6 +699,10 @@ const (
 type DetachedAnnotationArguments struct {
 	// DeleteAction indicates the desired delete logic when the detached annotation is present
 	DeleteAction DetachedDeleteAction `json:"deleteAction,omitempty"`
+	// Manager is an informal flag that tells that the annotation was set by an administrator.
+	// HostClaim controller will always set it to false and will never delete an annotation with
+	// manager set to true.
+	Manager bool `json:"manager,omitempty"`
 }
 
 // Match compares the saved status information with the name and

apis/metal3.io/v1alpha1/hostdeploypolicy_types.go

@@ -25,6 +25,9 @@ type HostDeployPolicySpec struct {
 	// HostClaimNamespaces constrains the namespaces of the HostClaims allowed
 	// to bind the BareMetalHosts in the same namespace as the HostDeployPolicy
 	HostClaimNamespaces *HostClaimNamespaces `json:"hostClaimNamespaces,omitempty"`
+	// AllowsDetachedMode is a boolean flag specifying if the hostClaim can set the
+	// detached annotation of the BareMetalHost.
+	AllowsDetachedMode bool `json:"allowsDetachedMode,omitempty"`
 }
 
 type HostClaimNamespaces struct {

config/base/crds/bases/metal3.io_hostdeploypolicies.yaml

@@ -39,6 +39,11 @@ spec:
           spec:
             description: HostDeployPolicySpec defines the desired state of HostDeployPolicy.
             properties:
+              allowsDetachedMode:
+                description: |-
+                  AllowsDetachedMode is a boolean flag specifying if the hostClaim can set the
+                  detached annotation of the BareMetalHost.
+                type: boolean
               hostClaimNamespaces:
                 description: |-
                   HostClaimNamespaces constrains the namespaces of the HostClaims allowed

config/render/capm3.yaml

@@ -2248,6 +2248,11 @@ spec:
           spec:
             description: HostDeployPolicySpec defines the desired state of HostDeployPolicy.
             properties:
+              allowsDetachedMode:
+                description: |-
+                  AllowsDetachedMode is a boolean flag specifying if the hostClaim can set the
+                  detached annotation of the BareMetalHost.
+                type: boolean
               hostClaimNamespaces:
                 description: |-
                   HostClaimNamespaces constrains the namespaces of the HostClaims allowed

internal/testutil/common.go

@@ -261,7 +261,7 @@ func (hb *HostClaimBuilder) SetMetaData(mdata string) *HostClaimBuilder {
 	return hb
 }
 
-func (hb *HostClaimBuilder) SetNetworData(ndata string) *HostClaimBuilder {
+func (hb *HostClaimBuilder) SetNetworkData(ndata string) *HostClaimBuilder {
 	hb.hostClaim.Spec.NetworkData = &corev1.SecretReference{Name: ndata}
 	return hb
 }
@@ -360,3 +360,8 @@ func (hb *HostDeployPolicyBuilder) AcceptRegexp(re string) *HostDeployPolicyBuil
 	spec.HostClaimNamespaces.NameMatches = re
 	return hb
 }
+
+func (hb *HostDeployPolicyBuilder) AllowsDetachedMode() *HostDeployPolicyBuilder {
+	hb.hostDeployPolicy.Spec.AllowsDetachedMode = true
+	return hb
+}