Skip to content

🌱 Set manager TLS default back to unset#3153

Merged
metal3-io-bot merged 1 commit intometal3-io:mainfrom
Nordix:peppi-lotta/return-tls-default-to-unset
Apr 21, 2026
Merged

🌱 Set manager TLS default back to unset#3153
metal3-io-bot merged 1 commit intometal3-io:mainfrom
Nordix:peppi-lotta/return-tls-default-to-unset

Conversation

@peppi-lotta
Copy link
Copy Markdown
Member

@peppi-lotta peppi-lotta commented Apr 10, 2026 •
edited
Loading

I'm removing tls flag from manager so that the project is not forcing any selection but we rely on the actual default.

In CAPM3 I'm adding overlays that apply the flag when e2e test are run: metal3-io/cluster-api-provider-metal3#3187

What this PR does / why we need it:

Fixes #

Checklist:

  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • E2E tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 10, 2026
@peppi-lotta
Set manager TLS default back to unset
fcf14ba 
Signed-off-by: peppi-lotta <peppi-lotta.saari@est.tech>
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/return-tls-default-to-unset branch from 2e2f63e to fcf14ba Compare April 10, 2026 12:17
tuminoid
tuminoid reviewed Apr 13, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2026
kashifest
kashifest reviewed Apr 13, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whats the reason behind the unsetting? Can you put some context in the description?

@peppi-lotta
Copy link
Copy Markdown
Member Author

peppi-lotta commented Apr 13, 2026

whats the reason behind the unsetting? Can you put some context in the description?

I updated the description.

Sunnatillo
Sunnatillo reviewed Apr 13, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peppi-lotta peppi-lotta mentioned this pull request Apr 15, 2026
Open
4 tasks
Rozzii
Rozzii reviewed Apr 17, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Rozzii Rozzii left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is ok for me and my downstream.
/hold
But let's ask other users too @zaneb @dtantsur @diconico07 @pierrecregut
/approved

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2026
@Rozzii
Copy link
Copy Markdown
Member

Rozzii commented Apr 17, 2026

/approve

@metal3-io-bot
Copy link
Copy Markdown
Contributor

metal3-io-bot commented Apr 17, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Rozzii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2026
@Rozzii Rozzii moved this to BMO WIP in Metal3 - Roadmap Apr 17, 2026
@diconico07
Copy link
Copy Markdown

diconico07 commented Apr 17, 2026

no problem with that change on my side 👍

@zaneb
Copy link
Copy Markdown
Member

zaneb commented Apr 17, 2026

We don't use these manifests downstream, so no objections here.

@Sunnatillo
Copy link
Copy Markdown
Member

Sunnatillo commented Apr 20, 2026

@Rozzii Lets unhold this, since we have enough response.

@pierrecregut
Copy link
Copy Markdown
Contributor

pierrecregut commented Apr 20, 2026

fine with me too

@tuminoid
Copy link
Copy Markdown
Member

tuminoid commented Apr 21, 2026

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 21, 2026
@metal3-io-bot metal3-io-bot merged commit 7f3d82a into metal3-io:main Apr 21, 2026
35 checks passed
@github-project-automation github-project-automation Bot moved this from BMO WIP to Done / Closed in Metal3 - Roadmap Apr 21, 2026
@metal3-io-bot metal3-io-bot deleted the peppi-lotta/return-tls-default-to-unset branch April 21, 2026 04:12
@metal3-io-bot metal3-io-bot added this to the BMO - v0.13 milestone Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tuminoid tuminoid tuminoid left review comments

@Rozzii Rozzii Rozzii left review comments

@Sunnatillo Sunnatillo Sunnatillo left review comments

@kashifest kashifest kashifest left review comments

@honza honza Awaiting requested review from honza

@iurygregory iurygregory Awaiting requested review from iurygregory

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

Metal3 - Roadmap
Status: Done / Closed

Milestone

BMO - v0.13

Development

Successfully merging this pull request may close these issues.

9 participants

@peppi-lotta @Rozzii @metal3-io-bot @diconico07 @zaneb @Sunnatillo @pierrecregut @tuminoid @kashifest