Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Release v1.8.3 #844

Merged
merged 1 commit into from
Jan 8, 2025
Merged

🚀 Release v1.8.3 #844

merged 1 commit into from
Jan 8, 2025

Conversation

peppi-lotta
Copy link
Member

What this PR does / why we need it: make patch release v1.8.3

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 7, 2025
@adilGhaffarDev
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2025
@adilGhaffarDev
Copy link
Member

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Contributor

@adilGhaffarDev: adilGhaffarDev unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file.

In response to this:

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tuminoid
tuminoid reviewed Jan 7, 2025
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/hold
Let's make 1.9.2 first, and see if the container building works. If it does, then unhold this.

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 7, 2025
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2025
@tuminoid
Copy link
Member

tuminoid commented Jan 7, 2025

/approve

/hold Let's make 1.9.2 first, and see if the container building works. If it does, then unhold this.

OK, we have a fix in place, unhold to try it out.

@peppi-lotta
Copy link
Member Author

@tuminoid Could you override the tests please?

@tuminoid
Copy link
Member

tuminoid commented Jan 7, 2025

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Contributor

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mquhuy
Copy link
Member

mquhuy commented Jan 7, 2025

@peppi-lotta The fix for release wf works on release v1.9.2. Could you rebase this PR, to make sure it has that fix?

@peppi-lotta
🚀 Release v1.8.3
9f671f5 
Signed-off-by: peppi-lotta <[email protected]>
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2025
@adilGhaffarDev
Copy link
Member

/lgtm
Container image building worked fine for 1.9 patch release.
@tuminoid please unhold and override tests.

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2025
@tuminoid
Copy link
Member

tuminoid commented Jan 8, 2025

Container image building worked fine for 1.9 patch release.

It did not, it had permission issues. But that is fixed now. Let's see if we now get a clean run.
/unhold
/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 8, 2025
@metal3-io-bot
Copy link
Contributor

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main

In response to this:

Container image building worked fine for 1.9 patch release.

It did not, it had permission issues. But that is fixed now. Let's see if we now get a clean run.
/unhold
/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot merged commit bdfe131 into metal3-io:main Jan 8, 2025
11 checks passed
@metal3-io-bot metal3-io-bot deleted the release-notes-1.8.3 branch January 8, 2025 06:13
@metal3-io-bot metal3-io-bot added this to the IPAM - v1.10 milestone Jan 8, 2025
@adilGhaffarDev
Copy link
Member

It did not, it had permission issues. But that is fixed now. Let's see if we now get a clean run.

sorry I meant after the fix it worked fine 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@smoshiur1237 smoshiur1237 Awaiting requested review from smoshiur1237

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
IPAM - v1.10
Development

Successfully merging this pull request may close these issues.
5 participants
@peppi-lotta @adilGhaffarDev @metal3-io-bot @tuminoid @mquhuy