🌱 Use pynotify instead of inotify-tools

[elfosardo]

The inotify-tools last release is from september 2023
and last update in the repo is 7 months old (May 2024).
The inotify-tools package is not present in the EPEL10 repo
anymore while python3-inotify is in a native repository.
This change allows us to remove dependency from EPEL entirely.

Signed-off-by: Riccardo Pittau elfosardo@gmail.com

Closes #605

[elfosardo]

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

[dtantsur]

The change looks good. There are a few other places where inotify is used, could you update them as well?

Also note that pyinotify is even more ancient: its last release was in 2015. I guess it still works well if it's included in the repos.

[elfosardo]

The change looks good. There are a few other places where inotify is used, could you update them as well?

Also note that pyinotify is even more ancient: its last release was in 2015. I guess it still works well if it's included in the repos.

yes, I will update the other places too
my understanding is that even if pyinotify is older, it's still maintained and supported as package in the main repo, as you saw, which should grant higher compatibility than epel

[metal3-io-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [dtantsur]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[elfosardo]

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

[tuminoid]

Good thing about Python inotify packages is that they all just implement ctypes wrappers for libc's functionality and do not try to reinvent the wheel. Hence most of the fixes, barring language incompatibilities down the road, are coming from OS packages, and it is not as relevant to have the python package updating all the time.

[tuminoid]

/lgtm