Skip to content

🐛 remove faulty NUMPROC logic#639

Merged
metal3-io-bot merged 1 commit intometal3-io:release-28.0from
metal3-io-bot:cherry-pick-636-to-release-28.0
Mar 12, 2025
Merged

🐛 remove faulty NUMPROC logic#639
metal3-io-bot merged 1 commit intometal3-io:release-28.0from
metal3-io-bot:cherry-pick-636-to-release-28.0

Conversation

@metal3-io-bot
Copy link
Copy Markdown
Contributor

@metal3-io-bot metal3-io-bot commented Mar 12, 2025

This is an automated cherry-pick of #636

/assign tuminoid

@tuminoid
remove faulty NUMPROC logic
6926880 
This removes the faulty NUMPROC processor count detection logic from
the configure-ironic.sh. It used to limit CPU count to 4, but the
"fixed" version made it a MINIMUM of 4.

This detection has now been merged on the ironic api side, so we can
remote the note + the faulty logic, and just leave the minimal env
var there. 0 means ironic will run its autodetection logic and set
maximum of 4 cores.

This fix has been merged on the Ironic side already in 2020, so we
can backport this to all branches we have.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@metal3-io-bot metal3-io-bot mentioned this pull request Mar 12, 2025
Merged
@metal3-io-bot metal3-io-bot added this to the ironic-image - v28.0 milestone Mar 12, 2025
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 12, 2025
tuminoid
tuminoid reviewed Mar 12, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retitle 🐛 remove faulty NUMPROC logic
/test metal3-centos-e2e-integration-test-release-1-9 metal3-ubuntu-e2e-integration-test-release-1-9
/lgtm

@metal3-io-bot metal3-io-bot changed the title [release-28.0] 🐛 remove faulty NUMPROC logic 🐛 remove faulty NUMPROC logic Mar 12, 2025
@metal3-io-bot
Copy link
Copy Markdown
Contributor Author

metal3-io-bot commented Mar 12, 2025

@tuminoid: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test markdownlint

/test metal3-centos-e2e-integration-test-main

/test metal3-ubuntu-e2e-integration-test-main

/test shellcheck

The following commands are available to trigger optional jobs:

/test metal3-dev-env-integration-test-centos-main

/test metal3-dev-env-integration-test-ubuntu-main

Use /test all to run the following jobs that were automatically triggered:

shellcheck
Details

In response to this:

/retitle 🐛 remove faulty NUMPROC logic
/test metal3-centos-e2e-integration-test-release-1-9 metal3-ubuntu-e2e-integration-test-release-1-9
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 12, 2025
@tuminoid
Copy link
Copy Markdown
Member

tuminoid commented Mar 12, 2025

It seems were missing branch protections for the release-28.0, I'll configure them.

@tuminoid
Copy link
Copy Markdown
Member

tuminoid commented Mar 12, 2025

It seems were missing branch protections for the release-28.0, I'll configure them.

Hmm, 28.0 is configured to use main as tests in Prow?

@elfosardo
Copy link
Copy Markdown
Member

elfosardo commented Mar 12, 2025

It seems were missing branch protections for the release-28.0, I'll configure them.

dang! I forgot to ask for that, I don't have the rights

@elfosardo
Copy link
Copy Markdown
Member

elfosardo commented Mar 12, 2025

It seems were missing branch protections for the release-28.0, I'll configure them.

Hmm, 28.0 is configured to use main as tests in Prow?

yep most recent change there metal3-io/project-infra#964

@tuminoid
Copy link
Copy Markdown
Member

tuminoid commented Mar 12, 2025

It seems were missing branch protections for the release-28.0, I'll configure them.

Hmm, 28.0 is configured to use main as tests in Prow?

yep most recent change there metal3-io/project-infra#964

Sure, I'll fix it to be like that.

@tuminoid
Copy link
Copy Markdown
Member

tuminoid commented Mar 12, 2025

Done.

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@elfosardo
Copy link
Copy Markdown
Member

elfosardo commented Mar 12, 2025

/approve

@metal3-io-bot
Copy link
Copy Markdown
Contributor Author

metal3-io-bot commented Mar 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2025
@metal3-io-bot metal3-io-bot merged commit f374cad into metal3-io:release-28.0 Mar 12, 2025
8 checks passed
iurygregory pushed a commit to iurygregory/ironic-image that referenced this pull request Oct 11, 2025
@openshift-merge-bot
Merge pull request metal3-io#639 from openshift-cherrypick-robot/cher…
afb7947 
…ry-pick-638-to-release-4.18

[release-4.18] OCPBUGS-50641: Install python3-inotify pkg explicitly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tuminoid tuminoid tuminoid left review comments

@iurygregory iurygregory Awaiting requested review from iurygregory

@Rozzii Rozzii Awaiting requested review from Rozzii

Assignees

@tuminoid tuminoid

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

ironic-image - v28.0

Development

Successfully merging this pull request may close these issues.

3 participants

@metal3-io-bot @tuminoid @elfosardo