🌱 skip detection step with an explicit var when running IPE script #710
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
metal3-io-bot
added
the
needs-ok-to-test
|
Hi @pixelsoccupied. Thanks for your PR. I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
metal3-io-bot
added
the
size/S
pixelsoccupied
force-pushed
the
drop-fake-ip
branch
from
e9ce146 to
466b22e
Compare
|
/ok-to-test |
metal3-io-bot
added
ok-to-test
tuminoid
left a comment
tuminoid
left a comment
There was a problem hiding this comment.
Just some comments on the readability, not going to comment on the logic right now as I'm fresh back from vacations :)
/Cc @elfosardo @dtantsur
pixelsoccupied
force-pushed
the
drop-fake-ip
branch
from
c986f1a to
dd6b339
Compare
Signed-off-by: Nahian Pathan <[email protected]>
pixelsoccupied
force-pushed
the
drop-fake-ip
branch
from
dd6b339 to
684cbc7
Compare
|
/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main |
|
|
||
| # Hostname to use for the current conductor instance. | ||
| export IRONIC_CONDUCTOR_HOST=${IRONIC_CONDUCTOR_HOST:-${IRONIC_URL_HOST}} | ||
| export IRONIC_CONDUCTOR_HOST=${IRONIC_CONDUCTOR_HOST:-${IRONIC_URL_HOST:-localhost}} |
There was a problem hiding this comment.
Why is this needed? I really don't like the conductor name changed from whatever is auto-detected to just localhost.
| # Set dummy provisioning IP to avoid interface detection issues (not needed to run IPE to service `/metrics`) | ||
| export PROVISIONING_IP="127.0.0.1" | ||
| # Skip provisioning interface detection (not needed for exporter) | ||
| export SKIP_PROVISIONING_INTERFACE=true |
There was a problem hiding this comment.
I think we need to go down a different path instead of adding yet another undocumented variable. I suggest splitting the provisioning interface logic into a new bash helper and not including it automatically from configure-ironic.
Note that regardless of the implementation, configure-ironic now needs to handle non-existing IRONIC_IP. This is the hardest part, but it's also the case here.
…al-build NO-ISSUE: Documented prerequisites for building ironic-image locally
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
metal3-io-bot
added
the
lifecycle/stale
5 participants
What this PR does / why we need it:
Instead of dummy variable to satisfy existing scripts (heavily used by Ironic)...added an env that is used to optionally skip checks that are not needed to run IPE as a service.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes # #700 (comment)
/cc @tuminoid
/cc @iurygregory
/cc @elfosardo
/cc @dtantsur