Skip to content

🐛 Revert "Fix dnsmasq config ipv6 issues"#723

Merged
metal3-io-bot merged 1 commit intomainfrom
revert-708-nuhakala/dnsmasq_ipv6_fix
Aug 8, 2025
Merged

🐛 Revert "Fix dnsmasq config ipv6 issues"#723
metal3-io-bot merged 1 commit intomainfrom
revert-708-nuhakala/dnsmasq_ipv6_fix

Conversation

@elfosardo
Copy link
Member

Reverts #708

After testing this patch on an actual ipv6 deployment, we've verified that this change breaks dnsmasq and ip assignment
The router option does work as expected instead

dnsmasq: started, version 2.85 DNS disabled
dnsmasq: compile time options: IPv6 GNU-getopt DBus no-UBus no-i18n IDN2 DHCP DHCPv6 no-Lua TFTP no-conntrack ipset auth cryptohash DNSSEC loop-detect inotify dumpfile
dnsmasq-dhcp: DHCPv6, IP range fd00:1101::a -- fd00:1101::ffff:ffff:ffff:fffe, lease time 1d
dnsmasq-dhcp: router advertisement on fd00:1101::
dnsmasq-dhcp: RTR-ADVERT(enp1s0) fd00:1101::
dnsmasq-dhcp: IPv6 router advertisement enabled
dnsmasq-dhcp: DHCP, sockets bound exclusively to interface enp1s0

@metal3-io-bot metal3-io-bot requested review from Rozzii and zaneb August 8, 2025 07:58
@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 8, 2025
@Rozzii
Copy link
Member

Rozzii commented Aug 8, 2025

@nuhakala

@Rozzii
Copy link
Member

Rozzii commented Aug 8, 2025

/cc @nuhakala

@metal3-io-bot metal3-io-bot requested a review from nuhakala August 8, 2025 08:02
Signed-off-by: Riccardo Pittau <elfosardo@gmail.com>
@elfosardo elfosardo force-pushed the revert-708-nuhakala/dnsmasq_ipv6_fix branch from 3175b56 to 597d985 Compare August 8, 2025 08:12
@elfosardo elfosardo changed the title Revert ":bug: Fix dnsmasq config ipv6 issues" 🐛 Revert "🐛 Fix dnsmasq config ipv6 issues" Aug 8, 2025
@elfosardo elfosardo changed the title 🐛 Revert "🐛 Fix dnsmasq config ipv6 issues" 🐛 Revert "Fix dnsmasq config ipv6 issues" Aug 8, 2025
@elfosardo
Copy link
Member Author

/cc @dtantsur @iurygregory

@Rozzii
Copy link
Member

Rozzii commented Aug 8, 2025

Let's have a discussion about this because in case #708 is faulty we have a faulty way to deploy ipv6 only environment in dev-env too and need to fix how we evaluate ipv6 fixes.

@elfosardo
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@elfosardo
Copy link
Member Author

/hold
until we have discussed this

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 8, 2025
@Rozzii
Copy link
Member

Rozzii commented Aug 8, 2025

/hold cancel
Let's revert until we 100% clarified the expected content of the config .
/lgtm

@metal3-io-bot metal3-io-bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 8, 2025
@Rozzii
Copy link
Member

Rozzii commented Aug 8, 2025

/cherry-pick release-31.0.0

@metal3-io-bot
Copy link
Contributor

@Rozzii: once the present PR merges, I will cherry-pick it on top of release-31.0.0 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-31.0.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@iurygregory
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iurygregory

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2025
@metal3-io-bot metal3-io-bot merged commit a6408a9 into main Aug 8, 2025
10 of 11 checks passed
@metal3-io-bot metal3-io-bot deleted the revert-708-nuhakala/dnsmasq_ipv6_fix branch August 8, 2025 10:30
@metal3-io-bot metal3-io-bot added this to the ironic-image - v32.0 milestone Aug 8, 2025
@metal3-io-bot
Copy link
Contributor

@Rozzii: cannot checkout release-31.0.0: error checking out "release-31.0.0": exit status 1 error: pathspec 'release-31.0.0' did not match any file(s) known to git

Details

In response to this:

/cherry-pick release-31.0.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tuminoid
Copy link
Member

tuminoid commented Aug 8, 2025

/cherry-pick release-31.0

@metal3-io-bot
Copy link
Contributor

@tuminoid: new pull request created: #725

Details

In response to this:

/cherry-pick release-31.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

hroyrh pushed a commit to hroyrh/ironic-image that referenced this pull request Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants