🐛 Centralize assignment of HTTP_PORT#728
Conversation
This is actually a bug fix, as ironic-common.sh, when invoked without setting HTTP_PORT, will fail, as no default value is defined. We set HTTP_PORT default value in ironic-common.sh to 80 as correctly written in the docs, and then export it. Removing assignments from all other scripts to avoid mistakes and confusion. Signed-off-by: Riccardo Pittau <elfosardo@gmail.com>
metal3-io-bot
added
the
size/XS
|
/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main |
tuminoid
left a comment
tuminoid
left a comment
There was a problem hiding this comment.
/lgtm
All of the script source ironic-common.sh so good simplification.
|
/hold |
metal3-io-bot
added
the
do-not-merge/hold
|
@Rozzii I don't think there's any instability left in ironic, CI integration job is passing just fine there |
Then I will remove the holds. |
metal3-io-bot
removed
the
do-not-merge/hold
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
github-project-automation
bot
moved this from Ironic-image WIP
to Done / Closed
in Metal3 - Roadmap
OCPBUGS-65969: Set the tls cacert path to writable mount when the IRONIC_CACERT_FILE is unset
5 participants
This is actually a bug fix, as ironic-common.sh, when invoked without setting HTTP_PORT, will fail, as no default value is defined.
We set HTTP_PORT default value in ironic-common.sh to 80 as correctly written in the docs, and then export it.
Removing assignments from all other scripts to avoid mistakes and confusion.
Signed-off-by: Riccardo Pittau elfosardo@gmail.com