🐛 Fix CentOS Stream 10 build#734
Merged
metal3-io-bot merged 1 commit intometal3-io:mainfrom Aug 26, 2025
Merged
Conversation
metal3-io-bot
added
the
size/XS
Member
Author
|
/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main |
During efi build, remove the shim package but not its dependencies to avoid conflict between architectures. This has been tested locally with both CS9 and CS10 base images. Signed-off-by: Riccardo Pittau <elfosardo@gmail.com>
elfosardo
force-pushed
the
fix-cs10-build
branch
from
8f1f223 to
078ab3d
Compare
Member
Author
|
/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main |
Member
|
/retest |
tuminoid
reviewed
Aug 21, 2025
Member
tuminoid
left a comment
tuminoid
left a comment
There was a problem hiding this comment.
/lgtm
Tested manually both CS9 and CS10 builds, they work.
Contributor
|
lgtm as well, I only tested with CS9 initially. |
Member
Author
|
/retest |
Member
Member
Author
|
/cc @iurygregory |
Member
|
Guys, please approve this so we get the CS10 not to fail every merge. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Rozzii The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During efi build, remove the shim package but not its
dependencies to avoid conflict between architectures.
This has been tested locally with both CS9 and CS10
base images.
Signed-off-by: Riccardo Pittau elfosardo@gmail.com