Skip to content

🐛 Change default json-rpc port to avoid possible conflicts#741

Merged
metal3-io-bot merged 1 commit intometal3-io:mainfrom
elfosardo:metal3-json-rpc-port
Sep 9, 2025
Merged

🐛 Change default json-rpc port to avoid possible conflicts#741
metal3-io-bot merged 1 commit intometal3-io:mainfrom
elfosardo:metal3-json-rpc-port

Conversation

@elfosardo
Copy link
Member

@elfosardo elfosardo commented Aug 21, 2025

The default ironic json-rpc port is 8089
In certain scenarios (e.g. HA) this port may conflict with other
services (e.g. k-nmstate).
Even if it's a rare occurrence, we should change the default
port in metal3 to avoid such conflicts.
This patch introduces a variable that allows changing the json-rpc
port in the ironic configuration with a default value of 6189.

Signed-off-by: Riccardo Pittau elfosardo@gmail.com

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 21, 2025
@elfosardo
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@tuminoid
Copy link
Member

Please add proper description.

@elfosardo elfosardo force-pushed the metal3-json-rpc-port branch from e9e0cd0 to 258a1a6 Compare August 22, 2025 08:28
@dtantsur
Copy link
Member

dtantsur commented Sep 3, 2025

This change breaks IrSO's tests. We'll need metal3-io/ironic-standalone-operator#363 to merge first.

@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Sep 5, 2025
The default ironic json-rpc port is 8089
In certain scenarios (e.g. HA) this port may conflict with other
services (e.g. k-nmstate).
Even if it's a rare occurrence, we should change the default
port in metal3 to avoid such conflicts.
This patch introduces a variable that allows changing the json-rpc
port in the ironic configuration with a default value of 6189.

Signed-off-by: Riccardo Pittau <elfosardo@gmail.com>
Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
@dtantsur dtantsur force-pushed the metal3-json-rpc-port branch from 258a1a6 to 1c8ba33 Compare September 8, 2025 14:08
@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Sep 8, 2025
@dtantsur
Copy link
Member

dtantsur commented Sep 8, 2025

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main
/cc @tuminoid

I've updated the patch, PTAL

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2025
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iurygregory

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2025
@metal3-io-bot metal3-io-bot merged commit 771f133 into metal3-io:main Sep 9, 2025
9 checks passed
@metal3-io-bot metal3-io-bot added this to the ironic-image - v32.0 milestone Sep 9, 2025
elfosardo pushed a commit to elfosardo/ironic-image that referenced this pull request Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants