🐛 Change default json-rpc port to avoid possible conflicts#741
Merged
metal3-io-bot merged 1 commit intometal3-io:mainfrom Sep 9, 2025
Merged
🐛 Change default json-rpc port to avoid possible conflicts#741metal3-io-bot merged 1 commit intometal3-io:mainfrom
metal3-io-bot merged 1 commit intometal3-io:mainfrom
Conversation
Member
Author
|
/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main |
Member
|
Please add proper description. |
e9e0cd0 to
258a1a6
Compare
dtantsur
reviewed
Sep 3, 2025
Member
|
This change breaks IrSO's tests. We'll need metal3-io/ironic-standalone-operator#363 to merge first. |
The default ironic json-rpc port is 8089 In certain scenarios (e.g. HA) this port may conflict with other services (e.g. k-nmstate). Even if it's a rare occurrence, we should change the default port in metal3 to avoid such conflicts. This patch introduces a variable that allows changing the json-rpc port in the ironic configuration with a default value of 6189. Signed-off-by: Riccardo Pittau <elfosardo@gmail.com> Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
258a1a6 to
1c8ba33
Compare
Member
|
/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main I've updated the patch, PTAL |
iurygregory
approved these changes
Sep 9, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iurygregory The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
elfosardo
pushed a commit
to elfosardo/ironic-image
that referenced
this pull request
Dec 15, 2025
OKD-310: Minor cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default ironic json-rpc port is 8089
In certain scenarios (e.g. HA) this port may conflict with other
services (e.g. k-nmstate).
Even if it's a rare occurrence, we should change the default
port in metal3 to avoid such conflicts.
This patch introduces a variable that allows changing the json-rpc
port in the ironic configuration with a default value of 6189.
Signed-off-by: Riccardo Pittau elfosardo@gmail.com