🌱 Allow a custom Ironic/Sushy source in IrSO functional tests#749
🌱 Allow a custom Ironic/Sushy source in IrSO functional tests#749metal3-io-bot merged 1 commit intometal3-io:mainfrom
Conversation
metal3-io-bot
added
the
size/S
|
/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main Irrelevant |
|
@dtantsur: Overrode contexts on behalf of dtantsur: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
diconico07
left a comment
diconico07
left a comment
There was a problem hiding this comment.
Apart from the delete part, lgtm
dtantsur
force-pushed
the
irso-functional
branch
from
72a7bd0 to
81750f3
Compare
|
/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main Irrelevant |
|
@dtantsur: Overrode contexts on behalf of dtantsur: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: diconico07, iurygregory The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
tuminoid
left a comment
tuminoid
left a comment
There was a problem hiding this comment.
Nit: better declare the arrays
This opens a way to run the tests in the Ironic CI. Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
dtantsur
force-pushed
the
irso-functional
branch
from
81750f3 to
f187dd4
Compare
|
/retest Kubernetes being ridiculous again |
|
/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main Irrelevant |
|
@dtantsur: Overrode contexts on behalf of dtantsur: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5 participants
This opens a way to run the tests in the Ironic CI.
Signed-off-by: Dmitry Tantsur dtantsur@protonmail.com