[WIP] Use heredoc syntax for RUN statements

[elfosardo]

No more && \

[metal3-io-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rozzii for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tuminoid]

Unless heredoc inherits the first set -e, then it'll remove && success chain guarantee, which is changing behavior.

[tuminoid]

Not sure if we gain anything here, besides the ipxe build part... ?

[elfosardo]

Not sure if we gain anything here, besides the ipxe build part... ?

@tuminoid yeah it's a small change, mostly to remove all the &&
I could add more stuff if you think it's not worth it as it is

[tuminoid]

Not sure if we gain anything here, besides the ipxe build part... ?

@tuminoid yeah it's a small change, mostly to remove all the && I could add more stuff if you think it's not worth it as it is

I'm just not sure why is it worth replacing a line with && with 5 lines (the last change in diff for example). What is the actual benefit? It is cleaner for the ipxe for sure, as its basically a script (we could put that into a script, like configure-nonroot.sh is) and that'd solve that.

[elfosardo]

I'm afraid podman version in the IrSO functional is too old for heredoc syntax :/

[elfosardo]

Not sure if we gain anything here, besides the ipxe build part... ?

@tuminoid yeah it's a small change, mostly to remove all the && I could add more stuff if you think it's not worth it as it is

I'm just not sure why is it worth replacing a line with && with 5 lines (the last change in diff for example). What is the actual benefit? It is cleaner for the ipxe for sure, as its basically a script (we could put that into a script, like configure-nonroot.sh is) and that'd solve that.

@tuminoid better readability, more clean, possibility to run commands as a script without the need to copy the script in the container and so saving a layer, quicker execution, to mention some
it's also not limited to RUN but also to other statements, I just didn't add them here

[elfosardo]

ubuntu has podman version 4.9 which has some issues parsing the heredoc syntax without adding the shell explicitely, but docker on the other hand uses sh by default breaking the workaround
wondering if we could install at least podman version 5 on ubuntu in some way

[elfosardo]

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

[elfosardo]

we should probably switch the IrSO functional to docker on ubuntu and the cs9/cs10 jobs to podman as they have newer versions
I'll do some tests and propose the changes

[elfosardo]

podman version on noble is just too old to support heredoc, we could use a static compiled version (I tested it and it works) to bump to 5.x to be able to support podman, but we probably need to discuss this first