Skip to content

🐛 Fix missing changeLogUrl in Renovate customManagers#830

Open
vbottu wants to merge 1 commit intometal3-io:mainfrom
vbottu:fix-renovate-changelog-url
Open

🐛 Fix missing changeLogUrl in Renovate customManagers#830
vbottu wants to merge 1 commit intometal3-io:mainfrom
vbottu:fix-renovate-changelog-url

Conversation

@vbottu
Copy link

@vbottu vbottu commented Dec 7, 2025

What this PR does / why we need it:
Adds changelogUrl configuration to the customManagers section for the openstack-ironic dependency. This ensures that Renovate PRs for ironic version updates include a changelog link comparing the old and new commit digests, making it easier to review what changed between versions.

Fixes #810

Checklist:

  • Documentation has been updated, if necessary.
  • Integration tests have been added, if necessary.

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign elfosardo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot
Copy link
Contributor

Hi @vbottu. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 7, 2025
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not work. We tried similar in #802.

$ npx --yes --package renovate -- renovate-config-validator
ERROR: Found errors in configuration
       "file": "renovate.json",
       "errors": [
         {
           "topic": "Configuration Error",
           "message": "Custom Manager contains disallowed fields: changelogUrl"
         }
       ]
 WARN: Found errors in configuration
       "file": "renovate.json",
       "warnings": [
         {
           "topic": "customManagers[0].changelogUrl",
           "message": "\"changelogUrl\" can't be used in \"customManagers\". Allowed objects: packageRules."
         }
       ]

@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Jan 22, 2026
@metal3-io-bot
Copy link
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Renovate generated PRs are still missing changeLogUrl

3 participants