Skip to content

Conversation

@diconico07
Copy link
Contributor

What this PR does / why we need it:

This PR adds a way to inject the Ironic CA as well as additional CA certificates into the IPA image, it allows removing the ipa-insecure flag and actually validate the Ironic certificate from the IPA.

This solution should work for both virtualmedia and PXE based deployments.

Checklist:

  • Documentation has been updated, if necessary.
  • Integration tests have been added, if necessary.

Signed-off-by: Nicolas Belouin <[email protected]>
@metal3-io-bot metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 15, 2025
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign iurygregory for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 15, 2025
@metal3-io-bot
Copy link
Contributor

Hi @diconico07. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 15, 2025
@diconico07
Copy link
Contributor Author

Putting as draft for now, as I didn't get time to test it works as expected in all situations (in particular I'll try to setup a PXE environment to test it works with PXE).
This is not the solution we currently use at SUSE to get rid of the ipa-insecure flag (we do the injection in the ipa downloader), but this one should be more future-proof as we can get IPA images that are not coming from the ipa downloader.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants