Skip to content

✨ Support multiple DHCP ranges via semicolon-separated DHCP_RANGE#918

Merged
metal3-io-bot merged 1 commit intometal3-io:mainfrom
holmboe:dhcp-multi-range
Feb 23, 2026
Merged

✨ Support multiple DHCP ranges via semicolon-separated DHCP_RANGE#918
metal3-io-bot merged 1 commit intometal3-io:mainfrom
holmboe:dhcp-multi-range

Conversation

@holmboe
Copy link
Contributor

@holmboe holmboe commented Feb 17, 2026

Summary

  • Split DHCP_RANGE env var on ; to emit one dhcp-range= line per entry in the dnsmasq Jinja2 template
  • Enables multiple subnets served via DHCPv6 relay agents from a single dnsmasq instance
  • Fully backward compatible: a single range with no semicolons produces identical output to before

Companion PR

Test plan

  • Verify single DHCP_RANGE=a::1,a::ff,64 (no semicolons) still renders one dhcp-range= line
  • Verify DHCP_RANGE=a::1,a::ff,64;b::1,b::ff,64 renders two dhcp-range= lines
  • Verify dnsmasq starts successfully with multiple ranges configured

Split DHCP_RANGE on ";" to emit one dhcp-range= line per entry,
enabling multiple subnets served via DHCPv6 relay agents. Backward
compatible: a single range with no semicolons produces the same
output as before.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Henrik Holmboe <henrik@dynamist.se>
@metal3-io-bot metal3-io-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 17, 2026
@metal3-io-bot
Copy link
Contributor

Hi @holmboe. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 17, 2026
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 17, 2026
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems safe and useful to me
/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2026
@lentzi90
Copy link
Member

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @Rozzii

@metal3-io-bot metal3-io-bot requested a review from Rozzii February 23, 2026 07:42
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Rozzii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2026
@metal3-io-bot metal3-io-bot merged commit e2456ad into metal3-io:main Feb 23, 2026
45 of 49 checks passed
@metal3-io-bot metal3-io-bot added this to the ironic-image - v35.0 milestone Feb 23, 2026
@holmboe holmboe deleted the dhcp-multi-range branch March 2, 2026 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants