✨ Support multiple DHCP ranges via semicolon-separated DHCP_RANGE#918
✨ Support multiple DHCP ranges via semicolon-separated DHCP_RANGE#918metal3-io-bot merged 1 commit intometal3-io:mainfrom
Conversation
Split DHCP_RANGE on ";" to emit one dhcp-range= line per entry, enabling multiple subnets served via DHCPv6 relay agents. Backward compatible: a single range with no semicolons produces the same output as before. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Henrik Holmboe <henrik@dynamist.se>
|
Hi @holmboe. Thanks for your PR. I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
lentzi90
left a comment
There was a problem hiding this comment.
Seems safe and useful to me
/lgtm
|
/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Rozzii The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
DHCP_RANGEenv var on;to emit onedhcp-range=line per entry in the dnsmasq Jinja2 templateCompanion PR
DHCP_RANGEenv varTest plan
DHCP_RANGE=a::1,a::ff,64(no semicolons) still renders onedhcp-range=lineDHCP_RANGE=a::1,a::ff,64;b::1,b::ff,64renders twodhcp-range=lines