🐛 Fix inspector.ipxe IPA URLs unreachable under iPXE TLS#955
Merged
metal3-io-bot merged 1 commit intometal3-io:mainfrom Mar 31, 2026
Merged
🐛 Fix inspector.ipxe IPA URLs unreachable under iPXE TLS#955metal3-io-bot merged 1 commit intometal3-io:mainfrom
metal3-io-bot merged 1 commit intometal3-io:mainfrom
Conversation
When IPXE_TLS_SETUP=true the cleartext httpd vhost blocks ironic-python-agent files via a FilesMatch deny rule, and the iPXE TLS vhost denies the entire /shared/html/images/ directory. inspector.ipxe.j2 renders all IPA kernel/ramdisk URLs against IRONIC_HTTP_URL (http://host:80), so they become unreachable during TLS-enabled inspection boot. Introduce IRONIC_IPA_BASE_URL in ironic-common.sh that resolves to the iPXE TLS endpoint when TLS is active, and falls back to IRONIC_HTTP_URL otherwise. Use it in inspector.ipxe.j2 for all IPA artifact URLs. Add a targeted FilesMatch grant on the iPXE TLS vhost so IPA files are served while the broader images/ deny stays in effect. Signed-off-by: Riccardo Pittau <elfosardo@gmail.com>
Member
Author
metal3-io-bot
added
the
size/S
Member
Author
|
/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main |
Member
|
I started reviewing this, I am fine making the inspector.ipxe compatible with the TLS enabled iPXE, but I have to think a bit about the file "file matching" access control you introduced to the apache endpoint. |
Rozzii
reviewed
Mar 30, 2026
Member
Rozzii
left a comment
Rozzii
left a comment
There was a problem hiding this comment.
/approve
After further consideration this PR should be fine IMO.
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Rozzii The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
github-project-automation
bot
moved this from Ironic-image WIP
to Done / Closed
in Metal3 - Roadmap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When IPXE_TLS_SETUP=true the cleartext httpd vhost blocks ironic-python-agent files via a FilesMatch deny rule, and the iPXE TLS vhost denies the entire /shared/html/images/ directory.
inspector.ipxe.j2 renders all IPA kernel/ramdisk URLs against IRONIC_HTTP_URL (http://host:80), so they become unreachable during TLS-enabled inspection boot.
Introduce IRONIC_IPA_BASE_URL in ironic-common.sh that resolves to the iPXE TLS endpoint when TLS is active, and falls back to IRONIC_HTTP_URL otherwise. Use it in inspector.ipxe.j2 for all IPA artifact URLs. Add a targeted FilesMatch grant on the iPXE TLS vhost so IPA files are served while the broader images/ deny stays in effect.
Fixes #954