✨Switch to default_deploy_interface = autodetect#956
✨Switch to default_deploy_interface = autodetect#956steveb wants to merge 1 commit intometal3-io:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
metal3-io-bot
added
the
needs-ok-to-test
|
Hi @steveb. Thanks for your PR. I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
metal3-io-bot
added
the
size/XS
steveb
changed the title
|
/ok-to-test |
metal3-io-bot
added
ok-to-test
|
@steveb you need to sign the commit |
|
/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main |
|
Test failures are unrelated. CI is broken because of v1beta2 changes happening in CAPM3. Should be fixed shortly. |
There was a problem hiding this comment.
Pull request overview
Updates the Ironic container’s default deploy interface configuration to use autodetect so deployments can automatically select bootc for oci:// images while preserving direct for existing scenarios.
Changes:
- Set
default_deploy_interfacefromdirecttoautodetect. - Enable the
autodetectdeploy interface and configure its priority order (bootcthendirect).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| auth_strategy = noauth | ||
| debug = true | ||
| default_deploy_interface = direct | ||
| default_deploy_interface = autodetect |
There was a problem hiding this comment.
Note that this value is most probably overridden by BMO, changing which will be much trickier (need to detect availability)
There was a problem hiding this comment.
I have a recorded demo of autodetect->bootc working with this change and upstream BMO. I don't see anywhere in BMO which sets deploy_interface=direct explicitly.
I do see some special handling which switches deploy_interface to ramdisk or custom-agent on a per node basis. It looks like the ramdisk path could be reworked at any time to defer to autodetect if that is the existing deploy interface.
|
/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main |
|
@steveb: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@steveb: The following tests failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This changes the default deploy interface from direct to autodetect[1]. For all existing supported scenarios this will result in the direct interface being used during deployment, but this will also enable bootc container images to be used for deployment. The check for bootc only occurs when the image source uses an oci:// URL protocol. [1] https://docs.openstack.org/ironic/latest/admin/interfaces/deploy.html#id6 Signed-off-by: Steve Baker <sbaker@redhat.com>
|
New changes are detected. LGTM label has been removed. |
What this PR does / why we need it:
This changes the default deploy interface from direct to autodetect[1]. For all existing supported scenarios this will result in the direct interface being used during deployment, but this will also enable bootc container images to be used for deployment.
The check for bootc only occurs when the image source uses an oci:// URL protocol.
[1] https://docs.openstack.org/ironic/latest/admin/interfaces/deploy.html#id6
Checklist: