🌱 Bump golang to v1.25 in go modules and golangci-lint to v2.10.1#600
Open
kashifest wants to merge 2 commits intometal3-io:mainfrom
Open
🌱 Bump golang to v1.25 in go modules and golangci-lint to v2.10.1#600kashifest wants to merge 2 commits intometal3-io:mainfrom
kashifest wants to merge 2 commits intometal3-io:mainfrom
Conversation
Also bump golangci-linter to v2.10.1 Signed-off-by: Kashif Khan <kashif.khan@est.tech>
Signed-off-by: Kashif Khan <kashif.khan@est.tech>
metal3-io-bot
added
the
size/M
Member
Author
|
/hold |
metal3-io-bot
added
the
do-not-merge/hold
Member
Author
|
This PR needs metal3-io/project-infra#1295 to go in first |
Member
|
/retest |
metal3-io-bot
removed
the
do-not-merge/hold
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tuminoid The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
Member
|
I assume we're doing the go.mod bump because it's going to be forced on us by gophercloud? Or are there other reasons? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixing linter findings
Fixes #580
Checklist: