Skip to content

🌱 Bump golangci-lint to v2.6.2#601

Open
kashifest wants to merge 1 commit intometal3-io:release-0.6from
Nordix:bump/golangci-lint-v2.6.2-release-0.6
Open

🌱 Bump golangci-lint to v2.6.2#601
kashifest wants to merge 1 commit intometal3-io:release-0.6from
Nordix:bump/golangci-lint-v2.6.2-release-0.6

Conversation

@kashifest
Copy link
Member

Manual cherry-pick of #438

Fixes #

Checklist:

  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • E2E tests have been added, if necessary.

Signed-off-by: Nuutti Hakala <nuutti.hakala@est.tech>
@metal3-io-bot metal3-io-bot added this to the IrSO - v0.6 milestone Mar 17, 2026
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign elfosardo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 17, 2026
@Rozzii
Copy link
Member

Rozzii commented Mar 17, 2026

Just to make sure.
/retest

@kashifest
Copy link
Member Author

kashifest commented Mar 17, 2026

I have no clue why this is failing now
any pointers @tuminoid @dtantsur @Rozzii ?

cd api; $(GOLANGCI_LINT) run -v --fast-only --path-prefix=api ./... --timeout=10m
cd test; $(GOLANGCI_LINT) run -v --fast-only --path-prefix=test ./... --timeout=10m

.PHONY: lint-full
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not want lint and lint full both to exist. Cherry-pick the lint-full -> lint commit here as well, or just manually do the same.

@dtantsur
Copy link
Member

The test failed because of the ramdisk downloader, which should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants