🐛 Do not set HostPorts when DisableHostNetwork is true

[dtantsur]

Refresh existing unit tests to be more meaningful and also cover Ports.

Signed-off-by: Dmitry Tantsur dtantsur@protonmail.com

[metal3-io-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tuminoid for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Copilot]

Pull request overview

Prevents HostPort assignment when host networking is disabled while preserving container ports and defaults.

Changes:

• Centralizes conditional HostPort construction.
• Adds fallback port defaults.
• Expands unit tests for TLS, custom ports, and disabled host networking.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
pkg/ironic/containers.go	Updates port construction and fallback defaults.
pkg/ironic/containers_test.go	Expands pod port and environment tests.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.