Skip to content

enable tpm simulation for virtual machines #1510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Rozzii
Copy link
Member

@Rozzii Rozzii commented Mar 19, 2025

This commit:

  • Appends the libvirt VM definition xml templates to include tpm simulation.

This commit is needed to enable the testing of use-cases where tpm features e.g. disk encryption, remote secure boot attestation, random hash generation, measured boot etc are used.

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 19, 2025
@Rozzii
Copy link
Member Author

Rozzii commented Mar 19, 2025

/test metal3-centos-e2e-integration-test-release-1-9
/test metal3-dev-env-integration-test-ubuntu-main

Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2025
@Rozzii
Copy link
Member Author

Rozzii commented Mar 19, 2025

looks like the swtpm package is missing from the ubuntu based ci image so I will add it.

@Rozzii
Copy link
Member Author

Rozzii commented Mar 19, 2025

/test metal3-centos-e2e-integration-test-release-1-9
/test metal3-dev-env-integration-test-ubuntu-main

@metal3-io-bot metal3-io-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 19, 2025
This commit:
 - Appends the libvirt VM definition xml templates to include tpm simulation.

This commit is needed to enable the testing of use-cases where tpm features
e.g. disk encryption, remote secure boot attestation, random hash generation,
measured boot etc are used.

Signed-off-by: Adam Rozman <[email protected]>
@metal3-io-bot metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 19, 2025
@Rozzii
Copy link
Member Author

Rozzii commented Mar 19, 2025

/test metal3-centos-e2e-integration-test-release-1-9
/test metal3-dev-env-integration-test-ubuntu-main

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2025
@Rozzii
Copy link
Member Author

Rozzii commented Mar 20, 2025

I am checking, even though it runs the swtpm install QEMU complains that swtpm is not in $PATH

@Rozzii
Copy link
Member Author

Rozzii commented Apr 24, 2025

/test metal3-dev-env-integration-test-ubuntu-main

@tuminoid
Copy link
Member

tuminoid commented May 9, 2025

/test metal3-centos-e2e-integration-test-release-1-10

Just using this PR to register 1.10 tests in GH.

@tuminoid
Copy link
Member

/retest

@metal3-io-bot
Copy link
Collaborator

@Rozzii: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
metal3-dev-env-integration-test-ubuntu-main 8ac904a link true /test metal3-dev-env-integration-test-ubuntu-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@metal3-io-bot
Copy link
Collaborator

@Rozzii: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
metal3-dev-env-integration-test-ubuntu-main 8ac904a link true /test metal3-dev-env-integration-test-ubuntu-main

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants