-
Notifications
You must be signed in to change notification settings - Fork 125
enable tpm simulation for virtual machines #1510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
/test metal3-centos-e2e-integration-test-release-1-9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
looks like the swtpm package is missing from the ubuntu based ci image so I will add it. |
/test metal3-centos-e2e-integration-test-release-1-9 |
This commit: - Appends the libvirt VM definition xml templates to include tpm simulation. This commit is needed to enable the testing of use-cases where tpm features e.g. disk encryption, remote secure boot attestation, random hash generation, measured boot etc are used. Signed-off-by: Adam Rozman <[email protected]>
/test metal3-centos-e2e-integration-test-release-1-9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I am checking, even though it runs the swtpm install QEMU complains that swtpm is not in $PATH |
/test metal3-dev-env-integration-test-ubuntu-main |
/test metal3-centos-e2e-integration-test-release-1-10 Just using this PR to register 1.10 tests in GH. |
/retest |
@Rozzii: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@Rozzii: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This commit:
This commit is needed to enable the testing of use-cases where tpm features e.g. disk encryption, remote secure boot attestation, random hash generation, measured boot etc are used.