Skip to content

Conversation

@peppi-lotta
Copy link
Member

When IPAM was made into a provider for CAPI the way is deployed was changed. This required a different way of deploying in older and newer versions. Now that v1.9.x is no longer tested, these temporary changes can be removed.

@metal3-io-bot metal3-io-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 22, 2025
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/remove-ipam-related-temp-changes branch from dbffc79 to 32d9577 Compare December 22, 2025 13:53
@Sunnatillo
Copy link
Member

/test metal3-centos-e2e-integration-test-release-1-12 metal3-centos-e2e-integration-test-release-1-11 metal3-dev-env-integration-test-ubuntu-main

@Sunnatillo
Copy link
Member

You are pushing commit of previous PR to this one as well:
https://github.com/metal3-io/metal3-dev-env/pull/1613/commits

When IPAM was made into a provider for CAPI
the way it is deployed was changed. This required a different way of
deploying in older and newer version. Now that v1.9.x is no
longer tested, these temporary changes can be removed.

Signed-off-by: peppi-lotta <[email protected]>
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/remove-ipam-related-temp-changes branch from 32d9577 to fa73eea Compare December 23, 2025 07:16
@peppi-lotta
Copy link
Member Author

/test metal3-centos-e2e-integration-test-release-1-12 metal3-centos-e2e-integration-test-release-1-11 metal3-dev-env-integration-test-ubuntu-main

Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@Sunnatillo
Copy link
Member

/cc @adilGhaffarDev @lentzi90

Copy link
Member

@adilGhaffarDev adilGhaffarDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 29, 2025
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90, Sunnatillo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 29, 2025
@metal3-io-bot metal3-io-bot merged commit fa0771f into metal3-io:main Dec 29, 2025
8 checks passed
@metal3-io-bot metal3-io-bot deleted the peppi-lotta/remove-ipam-related-temp-changes branch December 29, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants