Default to Kind and in-cluster Ironic via IRSO - #1692
Conversation
|
/test ? |
|
Skipping CI for Draft Pull Request. |
metal3-io-bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
metal3-io-bot
added
the
size/L
|
/test metal3-centos-e2e-feature-test-main-pivoting |
| export CAPM3RELEASEBRANCH="${CAPM3RELEASEBRANCH:-main}" | ||
|
|
||
| export USE_IRSO="${USE_IRSO:-false}" | ||
| export USE_IRSO="${USE_IRSO:-true}" |
There was a problem hiding this comment.
Are we going to support deployments that don't use IrSO? Or is it for stable branches?
There was a problem hiding this comment.
for CI no but user can still user run-local and deploy scripts for development purposes.
We will move those scripts from bmo to dev-env.
| when: BOOTSTRAP_CLUSTER == "kind" | ||
|
|
||
| - name: Remove Ironic from source cluster (minikube cluster) | ||
| - name: Remove IRSO operator from source cluster (kind cluster) |
There was a problem hiding this comment.
Ok, i will test it and see how it goes.
| state: absent | ||
| kubeconfig: "/tmp/kubeconfig-{{ CLUSTER_NAME }}.yaml" | ||
|
|
||
| - name: Remove IRSO operator from target cluster |
| environment: | ||
| CONTAINER_RUNTIME: "{{ CONTAINER_RUNTIME }}" | ||
| - name: Install IRSO operator in Source cluster | ||
| shell: "make -C {{ IRSOPATH }} install deploy IMG={{ IRSO_IMAGE }}" |
There was a problem hiding this comment.
Are we planning to ever use IrSO from source (e.g. for the CI)? If not, you may be better off using released manifests.
There was a problem hiding this comment.
In CI no, in CI we will always use release branches. I will fix this.
cfd46d7 to
d3e3be2
Compare
|
/test metal3-dev-env-integration-test-ubuntu-main |
d3e3be2 to
fcfa9a1
Compare
|
/test metal3-dev-env-integration-test-ubuntu-main |
fcfa9a1 to
5b06f4d
Compare
|
/test metal3-dev-env-integration-test-ubuntu-main |
1 similar comment
|
/test metal3-dev-env-integration-test-ubuntu-main |
5b06f4d to
8bf9321
Compare
|
/test metal3-dev-env-integration-test-ubuntu-main |
|
@adilGhaffarDev: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@adilGhaffarDev: The following tests failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
- Remove minikube support and standardize on Kind as the only bootstrap cluster option (tilt still supported for development) - Change USE_IRSO default from "false" to "true" to run Ironic inside the Kubernetes cluster using ironic-standalone-operator - Add setup_kind_provisioning_network() to connect Kind node to the provisioning bridge via veth pair when using IRSO - Update pivot/repivot tests to use IRSO (Ironic CR) instead of container-based Ironic deployment This simplifies the deployment architecture by: - Using a single bootstrap cluster type (Kind) for all environments - Using in-cluster Ironic for both management and target clusters - Aligning with the recommended production deployment model To run Ironic locally (old behavior): export USE_IRSO="false" Signed-off-by: Muhammad Adil Ghaffar <muhammad.adil.ghaffar@est.tech>
8bf9321 to
5cbd071
Compare
3 participants
This PR simplifies metal3-dev-env by standardizing on Kind as the only
bootstrap cluster and using ironic-standalone-operator (IRSO) for
in-cluster Ironic deployment by default.
This PR is doing following:
cluster option (tilt still supported for development)
the Kubernetes cluster using ironic-standalone-operator
provisioning bridge via veth pair when using IRSO
container-based Ironic deployment
This simplifies the deployment architecture by:
To run Ironic locally: export USE_IRSO="false"
Part of #1691