Make dev-env logs less noisy for Make - #1705
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
metal3-io-bot
added
the
size/M
|
/test metal3-dev-env-integration-test-ubuntu-main |
|
/copilot-review |
|
Copilot code review has been requested by @UncivilizedGhost. Please allow a few moments for the review to be added. |
There was a problem hiding this comment.
Pull request overview
This pull request reduces the verbosity/noise of make runs in metal3-dev-env by suppressing expected/low-signal output from package installs, container image operations, cluster creation, and Ansible tasks.
Changes:
- Add “quiet”/lower-verbosity flags for
apt-get,pip, container runtime pulls/pushes,skopeo copy,kind create cluster, andclusterctl init. - Adjust Ansible tasks to avoid reporting expected
virsh/firewalldconditions as errors. - Suppress Git’s detached-HEAD advice during runs.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
01_prepare_host.sh |
Adds quieter apt-get/pip usage and suppresses Git detached-HEAD advice. |
02_configure_host.sh |
Quiets container image pushes/removals and skopeo copy output during local registry population. |
03_launch_mgmt_cluster.sh |
Reduces clusterctl init verbosity, quiets kind create cluster, and quiets runtime image push. |
ansible.cfg |
Disables Ansible deprecation warnings to reduce log noise. |
host_cleanup.sh |
Attempts to undo the Git detached-HEAD advice suppression during cleanup. |
lib/image_prepull.sh |
Quiets container runtime image pulls during pre-pull. |
vm-setup/roles/firewall/tasks/iptables.yaml |
Adds a check to only stop firewalld when present (avoids expected “not found” errors). |
vm-setup/roles/libvirt/tasks/vm_setup_tasks.yml |
Uses failed_when: false + rc checks so expected virsh “not found” cases don’t appear as fatal errors. |
Comments suppressed due to low confidence (1)
host_cleanup.sh:9
- Unconditionally unsetting
advice.detachedHeadcan delete an existing user preference. If you suppress it during setup, it’s safer to restore the previous value captured during setup (and only touch the global config when that capture file exists). Also, sourcing common.sh before restoration ensures${WORKING_DIR}is defined.
set -x
# Remove detachedHEAD advice suppression set during make
git config --global --unset advice.detachedHead || true
# shellcheck disable=SC1091
source lib/logging.sh
# shellcheck disable=SC1091
source lib/common.sh
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
7159ec4 to
5201df9
Compare
|
/test metal3-dev-env-integration-test-ubuntu-main |
Remove git detachedhand advice message. Add quiet flages to apt-get pip install, docker full, skopeo copy and kind create cluster to remove unnessary detail. Reduce clusterctl init verbosiry to level 3. Add Firewalld Ansible task to avoid error Modify virsh Ansible tasks to not appar as errors since they are expected. Reduce logs by ~400 lines. Signed-off-by: Saad Zia <saad.zia@est.tech>
5201df9 to
6b33713
Compare
|
/retest |
|
/test metal3-dev-env-integration-test-ubuntu-main |
Remove git detachedhand advice message.
Add quiet flages to apt-get pip install, docker full, skopeo copy and kind create cluster to remove unnessary detail.
Reduce clusterctl init verbosiry to level 3.
Add Firewalld Ansible task to avoid error
Modify virsh Ansible tasks to not appar as errors since they are expected.
git config --global advice.detachedHead falseNote: switching to '6.2.0'. You are in 'detached HEAD' state... Turn off this advice by setting config variable advice.detachedHead to falseapt-get -qflag addedGet:1 https://cli.github.com/packages stable InRelease [3917 B], Fetched 3917 B in 1s (6595 B/s), Reading package lists...pip install -qflag addedCollecting ansible==10.7.0, Using cached ansible-10.7.0-py3-none-any.whl.metadata (8.0 kB), Successfully installed MarkupSafe-3.0.3 PyYAML-6.0.3 ansible-10.7.0...docker pull --quietflag addedUsing default tag: latest, latest: Pulling from metal3-io/vbmc, Digest: sha256:ba34b6c57325d6a..., Status: Image is up to date for quay.io/metal3-io/vbmc:latestskopeo copy --quietflag addedGetting image source signatures, Copying blob sha256:d3c894b5b2b0fa..., Copying config sha256:217ab2f6b797d7..., Writing manifest to image destinationkind create cluster -qflag addedCreating cluster "kind"... ✓ Ensuring node image 🖼 ✓ Preparing nodes 📦 ✓ Starting control-plane 🕹️ Thanks for using kind! 😊clusterctl init -v3instead of-v5Creating CustomResourceDefinition="challenges.acme.cert-manager.io", Creating ServiceAccount="cert-manager-cainjector", Creating Issuer="test-selfsigned" (×44 retries), hundreds more linesfatal: [localhost]: FAILED! => {"msg": "Could not find the requested service firewalld: host"}, ...ignoringvirshAnsible tasks:failed_when: falseon pool/volume checksfatal: [localhost]: FAILED! => {"stderr": "error: failed to get pool 'oooq_pool'...Storage pool not found"}, ...ignoringThis will reduce logs by around 400 lines.