Skip to content

docs: Add IP reuse documentation - #700

Merged
metal3-io-bot merged 1 commit into
metal3-io:mainfrom
MaxRink:docs/update-ip-reuse
Aug 28, 2026
Merged

docs: Add IP reuse documentation#700
metal3-io-bot merged 1 commit into
metal3-io:mainfrom
MaxRink:docs/update-ip-reuse

Conversation

@MaxRink

@MaxRink MaxRink commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Split out from #683 as requested.

Changes:

  • Add CAPM3 IP reuse / BMH name-based preallocation documentation.
  • Document the BMH-based IPClaim name format and preAllocations example.
  • Add clusterctl and controller flag configuration details.

Related: metal3-io/cluster-api-provider-metal3#3111

@metal3-io-bot metal3-io-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 12, 2026
@metal3-io-bot

Copy link
Copy Markdown
Contributor

Hi @MaxRink. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 12, 2026
@MaxRink
MaxRink force-pushed the docs/update-ip-reuse branch from eefd324 to 87e41a8 Compare June 12, 2026 12:13
@tuminoid

Copy link
Copy Markdown
Member

/ok-to-test

@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 13, 2026
@tuminoid

Copy link
Copy Markdown
Member

/copilot-review

@metal3-io-bot
metal3-io-bot requested a review from Copilot June 13, 2026 08:23
@metal3-io-bot

Copy link
Copy Markdown
Contributor

Copilot code review has been requested by @tuminoid. Please allow a few moments for the review to be added.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds user-guide documentation for CAPM3’s IP reuse feature (BMH name-based preallocation), including how IPClaim names are derived, how to use IPPool preAllocations, and how to enable the feature via clusterctl variables or controller flags.

Changes:

  • Add a new CAPM3 “IP Reuse” documentation page describing the behavior, configuration, and troubleshooting steps.
  • Include the new page in the CAPM3 features list.
  • Add the new page to the user-guide table of contents (SUMMARY).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
docs/user-guide/src/SUMMARY.md Adds the new “IP Reuse” page to the book navigation.
docs/user-guide/src/capm3/ip_reuse.md New documentation page describing BMH name-based IP preallocation and configuration.
docs/user-guide/src/capm3/features.md Links the new “IP Reuse” page from the CAPM3 features index.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/user-guide/src/capm3/ip_reuse.md
Comment thread docs/user-guide/src/capm3/ip_reuse.md Outdated
Comment thread docs/user-guide/src/capm3/ip_reuse.md Outdated
Comment thread docs/user-guide/src/capm3/ip_reuse.md
@MaxRink
MaxRink force-pushed the docs/update-ip-reuse branch from 87e41a8 to ea18bf7 Compare June 16, 2026 09:55
@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Jun 18, 2026
@MaxRink
MaxRink force-pushed the docs/update-ip-reuse branch from ea18bf7 to df54439 Compare June 19, 2026 12:44
@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Jun 19, 2026

@lentzi90 lentzi90 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Please check the nits from copilot

@metal3-io-bot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2026
@MaxRink
MaxRink force-pushed the docs/update-ip-reuse branch from df54439 to 50de688 Compare June 24, 2026 13:33
@lentzi90

Copy link
Copy Markdown
Member

Thank you! All good from my side. Let's see if we can get @fmuyassarov to take a look!
/cc @fmuyassarov

@tuminoid

Copy link
Copy Markdown
Member

Thank you! All good from my side. Let's see if we can get @fmuyassarov to take a look! /cc @fmuyassarov

Ping @fmuyassarov

Signed-off-by: Maximilian Rink <maximilian.rink@telekom.de>
@MaxRink
MaxRink force-pushed the docs/update-ip-reuse branch from 50de688 to 9bc48b6 Compare August 28, 2026 01:27

@fmuyassarov fmuyassarov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2026
@metal3-io-bot
metal3-io-bot merged commit fa1c1d0 into metal3-io:main Aug 28, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants