docs: Add IP reuse documentation - #700
Conversation
|
Hi @MaxRink. Thanks for your PR. I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
eefd324 to
87e41a8
Compare
|
/ok-to-test |
|
/copilot-review |
|
Copilot code review has been requested by @tuminoid. Please allow a few moments for the review to be added. |
There was a problem hiding this comment.
Pull request overview
This PR adds user-guide documentation for CAPM3’s IP reuse feature (BMH name-based preallocation), including how IPClaim names are derived, how to use IPPool preAllocations, and how to enable the feature via clusterctl variables or controller flags.
Changes:
- Add a new CAPM3 “IP Reuse” documentation page describing the behavior, configuration, and troubleshooting steps.
- Include the new page in the CAPM3 features list.
- Add the new page to the user-guide table of contents (SUMMARY).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| docs/user-guide/src/SUMMARY.md | Adds the new “IP Reuse” page to the book navigation. |
| docs/user-guide/src/capm3/ip_reuse.md | New documentation page describing BMH name-based IP preallocation and configuration. |
| docs/user-guide/src/capm3/features.md | Links the new “IP Reuse” page from the CAPM3 features index. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
87e41a8 to
ea18bf7
Compare
ea18bf7 to
df54439
Compare
lentzi90
left a comment
There was a problem hiding this comment.
/approve
Please check the nits from copilot
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
df54439 to
50de688
Compare
|
Thank you! All good from my side. Let's see if we can get @fmuyassarov to take a look! |
Ping @fmuyassarov |
Signed-off-by: Maximilian Rink <maximilian.rink@telekom.de>
50de688 to
9bc48b6
Compare
Split out from #683 as requested.
Changes:
Related: metal3-io/cluster-api-provider-metal3#3111