Remove MariaDB parameters from dev-env integration test job - #1454
Merged
Conversation
Removes the `IRONIC_USE_MARIADB` (removed in #1710) and `BUILD_MARIADB_IMAGE_LOCALLY` (removed in #1698) environment passthroughs from the dev-env integration test Jenkins job. Both variables were removed from metal3-dev-env, so passing them here has no effect. Signed-off-by: Migi Jylhä <migi.jylha@est.tech>
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Sunnatillo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/test ? |
Member
|
/test metal3-dev-env-integration-test-ubuntu-main |
lentzi90
reviewed
Aug 4, 2026
lentzi90
left a comment
Member
There was a problem hiding this comment.
/hold
Just making sure the tests pass.
/lgtm
Member
|
/hold cancel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
IRONIC_USE_MARIADB(removed in #1710) andBUILD_MARIADB_IMAGE_LOCALLY(removed in #1698) environment passthroughs from the dev-env integration test Jenkins job. Both variables were removed from metal3-dev-env, so passing them here has no effect.