Skip to content

Add Credentials to alloy alloy logs to be streamed in capm3 - #1489

Merged
metal3-io-bot merged 1 commit into
metal3-io:mainfrom
Nordix:saad/alloy_add
Aug 20, 2026
Merged

Add Credentials to alloy alloy logs to be streamed in capm3#1489
metal3-io-bot merged 1 commit into
metal3-io:mainfrom
Nordix:saad/alloy_add

Conversation

@UncivilizedGhost

@UncivilizedGhost UncivilizedGhost commented Aug 17, 2026

Copy link
Copy Markdown
Member

@UncivilizedGhost
Add creditonals to alloy alloy logs to be streamed in capm3
655d862 
Credionals for loki
Signed-off-by: Saad Zia <saad.zia@est.tech>
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 17, 2026
adilGhaffarDev
adilGhaffarDev reviewed Aug 18, 2026
View reviewed changes

@adilGhaffarDev adilGhaffarDev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2026
@adilGhaffarDev

adilGhaffarDev commented Aug 18, 2026

Copy link
Copy Markdown
Member

/cc @tgerczei

@metal3-io-bot
metal3-io-bot requested a review from tgerczei August 18, 2026 09:40
@tgerczei

tgerczei commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

A sidenote: IIRC @Rozzii warned against leaking vars and suggested populating files instead.

@tgerczei

tgerczei commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

/approve

Sunnatillo
Sunnatillo reviewed Aug 20, 2026
View reviewed changes

@Sunnatillo Sunnatillo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot

metal3-io-bot commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Sunnatillo, tgerczei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2026
@Sunnatillo

Sunnatillo commented Aug 20, 2026

Copy link
Copy Markdown
Member

/override metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot

metal3-io-bot commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

@Sunnatillo: Overrode contexts on behalf of Sunnatillo: metal3-ubuntu-e2e-integration-test-main

Details

In response to this:

/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot
metal3-io-bot merged commit 8b6d965 into metal3-io:main Aug 20, 2026
11 checks passed
@metal3-io-bot
metal3-io-bot deleted the saad/alloy_add branch August 20, 2026 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elfosardo elfosardo Awaiting requested review from elfosardo
@kashifest kashifest Awaiting requested review from kashifest
@tgerczei tgerczei Awaiting requested review from tgerczei
2 more reviewers
@adilGhaffarDev adilGhaffarDev adilGhaffarDev left review comments
@Sunnatillo Sunnatillo Sunnatillo left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@UncivilizedGhost @adilGhaffarDev @tgerczei @metal3-io-bot @Sunnatillo