🌱 Add broken link check: pr and scheduled

[peppi-lotta]

These workflows can be called from the other Metal3 repos to test for broken links.
.github/workflows/broken-link-check.yml is for testing all md files in a repo
.github/workflows/pr-link-check.yml is for testing all .md files that have changed in a PR. This does not check all files but only the ones that have changed.

I've tested the pr workflow in situations listed below and it is giving the output I expect

• .md file is edited and doesn't have any link (pass)
• .md file is edited and has working links (pass)
• .md file is edited and has broken link (fail)
• pr does not have any edited .md files (pass)

Fixes broken links.

[metal3-io-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tuminoid for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tuminoid]

Just quick comment about the filenames at this point.

[Rozzii]

/override metal3-ubuntu-e2e-integration-test-main

[metal3-io-bot]

@Rozzii: Overrode contexts on behalf of Rozzii: metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Rozzii]

/lgtm

[tuminoid]

/hold

Since we're adding only the callable workflows here, we have no test to see if they work and multi-repo actions are painful to test. Should we have link checking enabled in project-infra (added in this same PR), which verified they work?

[peppi-lotta]

/hold

Since we're adding only the callable workflows here, we have no test to see if they work and multi-repo actions are painful to test. Should we have link checking enabled in project-infra (added in this same PR), which verified they work?

I have created two repos for myself to test the PR link check workflow.
Repo containing workflows: https://github.com/peppi-lotta/workflow-test (should have pretty much the same link check workflows as I've added here)
Repo where work flows have been called: https://github.com/peppi-lotta/test-pr (This project has open PRs where the link check has been ran)

This is what I was using to test that workflows are working when I was writhing them. Can these be used as proof that these workflows are working? Other wise I can add changes to enable workflows here.

[tuminoid]

/hold
Since we're adding only the callable workflows here, we have no test to see if they work and multi-repo actions are painful to test. Should we have link checking enabled in project-infra (added in this same PR), which verified they work?

I have created two repos for myself to test the PR link check workflow. Repo containing workflows: https://github.com/peppi-lotta/workflow-test (should have pretty much the same link check workflows as I've added here) Repo where work flows have been called: https://github.com/peppi-lotta/test-pr (This project has open PRs where the link check has been ran)

This is what I was using to test that workflows are working when I was writhing them. Can these be used as proof that these workflows are working? Other wise I can add changes to enable workflows here.

It is good that you have working setup to test this. I think we would like to have links checked here as well, so IMO we could add it here too.

[metal3-io-bot]

New changes are detected. LGTM label has been removed.

[tuminoid]

I'll review properly next week, but initially it looks as agreed and clearly finds some issues in the repo :)

[tuminoid]

Minor nits.

[peppi-lotta]

/retest

[tuminoid]

Some further nits, but this is otherwise looking good now.

[tuminoid]

Suggested change

	if [ -s changed-files.txt ]; then
	if [[ -s "changed-files.txt" ]]; then

[tuminoid]

Suggested change

	git diff --name-only origin/${{ github.event.pull_request.base.ref }}...${{ github.head_ref }} -- '*.md' > changed-files.txt
	git diff --name-only "origin/${{ github.event.pull_request.base.ref }}...${{ github.head_ref }}" -- "*.md" > changed-files.txt

[tuminoid]

Suggested change

	echo "foundFiles=true" >> $GITHUB_ENV
	echo "foundFiles=true" >> "${GITHUB_ENV}"