Skip to content

control rook image via chart #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aviramha merged 1 commit into from
Mar 30, 2026
Merged

control rook image via chart #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions deploy/k8s/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,10 @@ spec:
value: {{ .Values.sandbox.k8s.namespace | quote }}
- name: SANDCASTLE_ROOK_URL
value: {{ .Values.sandbox.k8s.rookUrl | default (printf "ws://%s.%s.svc.cluster.local:%d/rook/ws" (include "sandcastle.fullname" .) .Release.Namespace (.Values.port | int)) | quote }}
{{- if .Values.sandbox.k8s.image }}
- name: SANDCASTLE_K8S_IMAGE
value: {{ .Values.sandbox.k8s.image | quote }}
{{- end }}
{{- end }}
{{- if .Values.secretBackend.gcpProjectId }}
- name: GCP_PROJECT_ID
Expand Down
2 changes: 2 additions & 0 deletions deploy/k8s/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ sandbox:
enabled: false
# Namespace where sandbox pods are created.
namespace: "sandcastle-sandboxes"
# Container image used for sandbox pods (SANDCASTLE_K8S_IMAGE). Defaults to sandcastle's built-in default when empty.
image: ""
# URL that rook pods use to connect back to sandcastle. Leave empty to auto-compute
# from the release name, namespace, and port (recommended for in-cluster deployments).
rookUrl: ""
Expand Down
Loading