Open
Conversation
Contributor
|
Arifin -- Have you tried to contact @metalmatze out-of-band for a review of this PR? |
Owner
|
Oh. This ping is already helpful. |
metalmatze
reviewed
Mar 23, 2024
Owner
metalmatze
left a comment
There was a problem hiding this comment.
Some metric names should be updated to follow Prometheus naming conventions. That'd be good. Otherwise it looks great!
| timeout: timeout, | ||
|
|
||
| CPUMetrics: prometheus.NewDesc( | ||
| "digitalocean_monitoring_cpu", |
Owner
There was a problem hiding this comment.
Going with the other Prometheus metrics in the process Exporter this should probably have a _seconds_total suffix.
| append(labels, "mode"), nil, | ||
| ), | ||
| MemoryTotalMetrics: prometheus.NewDesc( | ||
| "digitalocean_monitoring_memory_total", |
Owner
There was a problem hiding this comment.
Should probably be bytes_total suffix
| labels, nil, | ||
| ), | ||
| MemoryFreeMetrics: prometheus.NewDesc( | ||
| "digitalocean_monitoring_memory_free", |
Owner
There was a problem hiding this comment.
_bytes suffix would be great.
| labels, nil, | ||
| ), | ||
| MemoryAvailableMetrics: prometheus.NewDesc( | ||
| "digitalocean_monitoring_memory_available", |
Owner
There was a problem hiding this comment.
_bytes suffix would be great.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support to retrieve metrics from DigitalOcean monitoring agent.