-
Notifications
You must be signed in to change notification settings - Fork 45
Perf improvements for exporter, instance & job support for Grafana #40
base: master
Are you sure you want to change the base?
Perf improvements for exporter, instance & job support for Grafana #40
Conversation
See [1] for details. [1] github.com/metalmatze/transmission-exporter/pull/40
This adds instance and job filters[1] to the dashboard so if you have multiple exporters running you can choose which one(s) to view. [1] https://prometheus.io/docs/concepts/jobs_instances/
After the first run, only fetch recently active torrents. This will improve RPC response times for Transmission instances with thousands of torrents. This is a port of leijurv's work[1] from his fork. Unlike that commit, I did not make any backwards incompatible changes. [1] metalmatze@c143ddb
This makes use of the new metric added in 5aac42a.
e0633c5
to
b0a0d7d
Compare
It's been a long time so I legitimately don't remember: what backwards incompatible changes did I make? also for what it's worth I slightly regret having added the per torrent metrics because now my prometheus is 300gb lol |
You dropped some metrics like leechers & seeders.
Yeah, it's a disk hog for sure :) |
These are floats in the RPC even though they contain integers, like 100.0. Without this change JSON unmarshalling fails.
Heyya, good work on the improvements! I've tested the build locally and on my case, the "Torrent" field is a bit of a problem as it will error the grafana out I have a modest 649 entries, though some with a long names so its kind of a problem. Removing the filter works for me. |
Glad you like it! I tested against a server with 347 entries, so I must have avoided the query length issue. I'll see if I can do anything about that. Maybe we can restrict the set somehow. |
I store my metrics under VictoriaMetrics and so far it adds about 200-300MB per-day just from the transmission exporter itself. Which is fine by me. But one of my suggestion is to use stats is it possible to use total uploaded instead of average uploaded in the stats table? or maybe change one of them like total uploaded 30d? |
I can add a second table, Does that sound OK? |
Sounds good by me, but for the |
Performance improvements
After the first run, only fetch recently active torrents. This improves RPC response times for Transmission instances with thousands of torrents.
This is a port of @leijurv's work from his fork. Including the new metrics,
peersSendingToUs
anddownloadedEver
. Unlike that commit, I did not make any backwards incompatible changes.Instance and job support for Grafana
This adds instance and job filters to the dashboard so if you have multiple exporters running you can choose which one(s) to view.
Here's how it looks:


I also adjusted a few panel widths for consistency.
Peers UL (uploading to us)
I also updated the stats table to make use of the new

peersSendingToUs
metric:This closes #32.