fix assert.rejects usage in tests#194
Merged
webketje merged 1 commit intometalsmith:masterfrom Mar 8, 2026
Merged
Conversation
`assert.rejects` needs to be awaited inside of the async test body if it is not the test is effectively ignored since any exceptions are thrown after the test function completes other changes: - `transform` option is required by plugin - wrapping a Promise returned by `Metalsmith` invocation is not necessary: `assert.rejects` takes a Promise as first argument see: https://nodejs.org/api/assert.html#assertrejectsasyncfn-error-message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assert.rejectsneeds to be awaited inside of the async test body.If it is not, the test is effectively ignored since any exceptions are thrown after the test function completes.
other changes:
transformoption is required by the pluginMetalsmithinvocation is not necessary:assert.rejectstakes a Promise as first argumentsee:
https://nodejs.org/api/assert.html#assertrejectsasyncfn-error-message