chore(api): improve getAsset and getAssetProof error messages

[armyhaylenko]

No description provided.

[StanChe]

This was previously deliberately aligned with the reference implementation response, glad to see this gone

[coderabbitai]

Summary by CodeRabbit

• Bug Fixes
  • Streamlined error messages for a clearer, more concise display when issues occur, ensuring users receive only the essential information.

Walkthrough

The changes update the error conversion logic in the API error module by simplifying the error messages. The verbose messages for the DasApiError::NoDataFoundError and DasApiError::ProofNotFound variants were replaced with shorter text versions. No public API declarations were altered.

Changes

File	Change Summary
nft_ingester/src/api/error.rs	Simplified error messages for DasApiError variants: changed NoDataFoundError from "Database Error: RecordNotFound Error: Asset Not Found" to "Asset Not Found", and ProofNotFound similarly.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 94db274 and e60fe6f.

📒 Files selected for processing (1)

• nft_ingester/src/api/error.rs (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: build-base-image
• GitHub Check: test
• GitHub Check: lint

🔇 Additional comments (2)

nft_ingester/src/api/error.rs (2)

72-72: Improved error message clarity.

The simplified error message "Asset Not Found" is more user-friendly and concise than the previous verbose version that exposed implementation details. This change aligns well with best practices for user-facing error messages.

---

87-87: Improved error message clarity.

The simplified error message "Asset Proof Not Found" effectively communicates the issue without revealing unnecessary implementation details. This makes the API more user-friendly while maintaining the essential information.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.