fix: resolve Anchor dependency conflicts in Rust client (#196)#237
Open
hasip-timurtas wants to merge 1 commit intometaplex-foundation:mainfrom
Open
Conversation
…ersions - Update solana-program from '> 1.14' to '^1.17' in clients/rust - Update solana-program-test and solana-sdk to '^1.17' for consistency - Resolves Pubkey type conflicts between Anchor and MPL Core - Fixes issue where users couldn't build Anchor projects with mpl-core Fixes metaplex-foundation#196
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Summary by CodeRabbit
WalkthroughThe dependency versions for Changes
Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes were found. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (2)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves dependency version conflicts between MPL Core Rust client and Anchor framework that prevented compilation of Anchor projects using MPL Core.
Problem
Issue #196: Users encountered
expected 'anchor_lang::prelude::Pubkey', found '__Pubkey'errors when building Anchor projects with MPL Core due to incompatiblesolana-programversion constraints.Solution
Updated
clients/rust/Cargo.tomldependency constraints:This aligns the client dependencies with the program's
solana-program = "^1.17"constraint, ensuring consistent dependency resolution.Testing
Impact
Enables developers to use MPL Core in Anchor-based applications without dependency conflicts.
Closes #196