Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions lib/pg.provider.js
Original file line number Diff line number Diff line change
Expand Up @@ -558,11 +558,17 @@ class PostgresProvider extends StorageProvider {
values.push(id.toString());
}
fields = fields.map(escapeIdentifier);
const createQuery =
`INSERT INTO ${escapeIdentifier(category)} ` +
`(${fields.join(', ')})` +
` VALUES (${generateQueryParams(fields.length)})` +
' RETURNING "Id"';

let createQuery = `INSERT INTO ${escapeIdentifier(category)} `;
if (fields.length !== 0) {
createQuery +=
`(${fields.join(', ')})` +
` VALUES (${generateQueryParams(fields.length)})`;
} else {
createQuery += 'DEFAULT VALUES';
}
createQuery += ' RETURNING "Id"';

const res = await client.query(createQuery, values);
return res.rows[0].Id;
};
Expand Down
3 changes: 3 additions & 0 deletions test/fixtures/pg-test-schemas/Local.category
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Local({
SomeData: { domain: 'Nomen' },
})
3 changes: 3 additions & 0 deletions test/fixtures/pg-test-schemas/OptionalRegistry.category
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Registry({
SomeData: { domain: 'Nomen' },
})
12 changes: 12 additions & 0 deletions test/pg.js
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,12 @@ metatests.test(
}
});

test.test('empty create on local category', async test => {
const id = await provider.create('Local', {});
test.assert(id);
test.end();
});

test.test('create on global category', async test => {
const { category, value } = record;
const id = await provider.create(category, value);
Expand All @@ -122,6 +128,12 @@ metatests.test(
}
});

test.test('empty create on global category', async test => {
const id = await provider.create('OptionalRegistry', {});
test.assert(id);
test.end();
});

test.test('create on ignored category', async test => {
try {
await provider.create('TestMemory', {
Expand Down