Security: limit memory consumption in receiveBody#341
Open
tomaioo wants to merge 9 commits into
Open
Conversation
The `receiveBody` function reads an incoming stream into memory by continuously pushing chunks into an array and concatenating them at the end. There is no limit on the maximum body size. An attacker could send a massive request body to exhaust server memory, leading to a Denial of Service (DoS). Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
| 'use strict'; | ||
|
|
||
| const receiveBody = async (stream) => { | ||
| const MAX_BODY_SIZE = 0xffffffff; |
Member
There was a problem hiding this comment.
4Gb gives attacker gives the attacker great opportunities and node.js will fail allocating such an array
Member
|
Co-authored-by: Timur Shemsedinov <timur.shemsedinov@gmail.com>
tshemsedinov
changed the title
receiveBody…great opportunities an Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
…great opportunities an Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
const MAX_BODY_SIZE = 10 * 1024 * 1024; ``` Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
Member
|
Tests fails @tomaioo because you removed new line at the end of the file |
…great opportunities an Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
const MAX_BODY_SIZE = 10 * 1024 * 1024; ``` Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Unbounded Memory Consumption in
receiveBodyProblem
Severity:
High| File:lib/network.js:L3The
receiveBodyfunction reads an incoming stream into memory by continuously pushing chunks into an array and concatenating them at the end. There is no limit on the maximum body size. An attacker could send a massive request body to exhaust server memory, leading to a Denial of Service (DoS).Solution
Implement a maximum body size limit. Track the total length of received chunks and abort the request (or throw an error) if it exceeds a predefined threshold.
Changes
lib/network.js(modified)